camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hadrian Zbarcea <hzbar...@gmail.com>
Subject Re: Should I create an JIRA issue for every commit?
Date Mon, 21 Jan 2008 21:10:26 GMT
Hi Roman,

No need for jiras for simple/cosmetic changes.

Cheers
hz

On Jan 21, 2008, at 4:02 PM, Roman Kalukiewicz wrote:

> The question is like in the subject: Should I create a JIRA issue for
> everything that I change, or not?
>
> As an example of such 'simple' change lets look at my forwarded  
> commit.
>
> Roman
>
> ---------- Forwarded message ----------
> From: romkal@apache.org <romkal@apache.org>
> Date: 21-01-2008 21:56
> Subject: svn commit: r614007 - in
> /activemq/camel/trunk/camel-core/src/test/java/org/apache/camel:
> ContextTestSupport.java ExchangeTestSupport.java
> model/XmlTestSupport.java
> To: camel-commits@activemq.apache.org
>
>
> Author: romkal
> Date: Mon Jan 21 12:56:08 2008
> New Revision: 614007
>
> URL: http://svn.apache.org/viewvc?rev=614007&view=rev
> Log:
> ContextTestSupport supports many RouteBuilders to be tested
> Tests without test methods made abstract so eclipse doesn't complain
> when executing them
>
> Modified:
>    activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/ 
> ContextTestSupport.java
>    activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/ 
> ExchangeTestSupport.java
>    activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/ 
> model/XmlTestSupport.java
>
> Modified: activemq/camel/trunk/camel-core/src/test/java/org/apache/ 
> camel/ContextTestSupport.java
> URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/ContextTestSupport.java?rev=614007&r1=614006&r2=614007&view=diff
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/ 
> ContextTestSupport.java
> (original)
> +++ activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/ 
> ContextTestSupport.java
> Mon Jan 21 12:56:08 2008
> @@ -24,6 +24,7 @@
> import org.apache.camel.component.mock.MockEndpoint;
> import org.apache.camel.impl.DefaultCamelContext;
> import org.apache.camel.impl.JndiRegistry;
> +import  
> org.apache.camel.processor.CreateRouteWithNonExistingEndpointTest;
> import org.apache.camel.spi.Language;
> import org.apache.camel.util.jndi.JndiTest;
>
> @@ -68,9 +69,11 @@
>         template = new CamelTemplate<Exchange>(context);
>
>         if (useRouteBuilder) {
> -            RouteBuilder builder = createRouteBuilder();
> -            log.debug("Using created route builder: " + builder);
> -            context.addRoutes(builder);
> +            RouteBuilder[] builders = createRouteBuilders();
> +            for (RouteBuilder builder : builders) {
> +                log.debug("Using created route builder: " + builder);
> +                context.addRoutes(builder);
> +            }
>         }
>         else {
>             log.debug("Using route builder from the created context:
> " + context);
> @@ -138,6 +141,16 @@
>         };
>     }
>
> +    /**
> +     * Factory method which derived classes can use to create an  
> array of
> +     * {@link RouteBuilder}s to define the routes for testing
> +     *
> +     * @see #createRouteBuilder()
> +     */
> +    protected RouteBuilder[] createRouteBuilders() throws Exception {
> +        return new RouteBuilder[] {createRouteBuilder()};
> +    }
> +
>     /**
>      * Resolves a mandatory endpoint for the given URI or an
> exception is thrown
>      *
>
> Modified: activemq/camel/trunk/camel-core/src/test/java/org/apache/ 
> camel/ExchangeTestSupport.java
> URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/ExchangeTestSupport.java?rev=614007&r1=614006&r2=614007&view=diff
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/ 
> ExchangeTestSupport.java
> (original)
> +++ activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/ 
> ExchangeTestSupport.java
> Mon Jan 21 12:56:08 2008
> @@ -25,7 +25,7 @@
>  *
>  * @version $Revision: 1.1 $
>  */
> -public class ExchangeTestSupport extends ContextTestSupport {
> +public abstract class ExchangeTestSupport extends  
> ContextTestSupport {
>     protected Exchange exchange;
>
>     /**
>
> Modified: activemq/camel/trunk/camel-core/src/test/java/org/apache/ 
> camel/model/XmlTestSupport.java
> URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/model/XmlTestSupport.java?rev=614007&r1=614006&r2=614007&view=diff
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/ 
> model/XmlTestSupport.java
> (original)
> +++ activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/ 
> model/XmlTestSupport.java
> Mon Jan 21 12:56:08 2008
> @@ -29,7 +29,7 @@
> /**
>  * @version $Revision: 1.1 $
>  */
> -public class XmlTestSupport extends TestSupport {
> +public abstract class XmlTestSupport extends TestSupport {
>     protected final transient Log log = LogFactory.getLog(getClass());
>     protected JAXBContext jaxbContext;


Mime
View raw message