camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Schneider (JIRA)" <>
Subject [jira] Updated: (CAMEL-272) Rework of File Component to Remove Tangles and simplify code
Date Tue, 29 Jan 2008 14:59:24 GMT


Christian Schneider updated CAMEL-272:


Hi Hadrian,

sorry that I reply so late. I was on a conference last week and had a bad flue afterwards.

I have created the patchfile like described in the wiki. But I am not so sure it is correct.
I have created a new directory impl and the patch looks not correct there. So I have also
attached complete copies of the source files in components/file as well as the corresponding

I have also updated my checkout before making the patch and copies so I hope there are no

Best regards


> Rework of File Component to Remove Tangles and simplify code
> ------------------------------------------------------------
>                 Key: CAMEL-272
>                 URL:
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>            Reporter: Christian Schneider
>            Assignee: Hadrian Zbarcea
>             Fix For: 1.3.0
>         Attachments:,, new no tangles.png, old.png, patch.txt,
> After my first smaller rework in issue camel-262 I now completely reworked the file component
to remove any cyclic references and clean up the code.
> The first thing I did was separating the FileComponent from the other classes in package
file by moving them to a new package .impl. This way I was able to remove the cycle between
the strategy package and the file package.
> The second step was to move all config data from FileEndPoint to a new class FileEndPointConfig.
This way I was able to remove the cycle between FileEndPoint, FileProducer and FileConsumer.
> Next I removed FileMessage and FileExchange and instead relied on the default objects.
The file is simply stored in DefaultMessage.body. There was even a comment in the code asking
if FileExchange was necessary before. So I hope this is ok?
> I had to adapt the tests to the new structure but only changed the tests where it was
absolutely necessary. All tests run fine.
> What do you think?

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message