camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hiram Chirino" <hi...@hiramchirino.com>
Subject Re: a few comments on SedaComponent
Date Fri, 05 Oct 2007 15:16:06 GMT
Yeah.. Fixed now.. To make it easier
I added a isRunAllowed() method to the base ServiceSupport class.

On 10/5/07, William Tam <email.wtam@gmail.com> wrote:
> Thanks Hiram.   Should we add a check for !isStopped() here as well?
>
>             if (exchange != null && !isStopping()) {
>                 processor.process(exchange, new AsyncCallback() {
>                     public void done(boolean sync) {
>                     }
>                 });
>             }
>
>
> On 10/5/07, Hiram Chirino <hiram@hiramchirino.com> wrote:
> > On 10/4/07, Hiram Chirino <hiram@hiramchirino.com> wrote:
> > > On 10/4/07, William Tam <email.wtam@gmail.com> wrote:
> > > > 2. In the SedaConsumer.run() method.  I think the two checks for
> > > > "!isStopping()" should be modified to: "!isStopping() &&
> > > > !isStopped()".  Otherwise, the consumer's thread can run forever since
> > > > it is possible for ServiceSupport.stop()  to change the stopping flag
> > > > to true and back to false before the consumer's thread has a chance to
> > > > check the stopping flag.
> > >
> > > Good catch!  Will fix.
> > >
> >
> > fixed in rev 582282
> >
> > > >
> > > > Regards,
> > > > William
> > > >
> > >
> > >
> > > --
> > > Regards,
> > > Hiram
> > >
> > > Blog: http://hiramchirino.com
> > >
> >
> >
> > --
> > Regards,
> > Hiram
> >
> > Blog: http://hiramchirino.com
> >
>


-- 
Regards,
Hiram

Blog: http://hiramchirino.com

Mime
View raw message