From commits-return-116931-archive-asf-public=cust-asf.ponee.io@camel.apache.org Fri Oct 2 12:21:53 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id D687F180630 for ; Fri, 2 Oct 2020 14:21:53 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 15C5A123A9E for ; Fri, 2 Oct 2020 12:21:53 +0000 (UTC) Received: (qmail 68228 invoked by uid 500); 2 Oct 2020 12:21:52 -0000 Mailing-List: contact commits-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list commits@camel.apache.org Received: (qmail 68219 invoked by uid 99); 2 Oct 2020 12:21:52 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Oct 2020 12:21:52 +0000 From: =?utf-8?q?GitBox?= To: commits@camel.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bcamel=5D_rgannu_commented_on_a_change_in_pull_requ?= =?utf-8?q?est_=234346=3A_CAMEL-15496=3A_Headers_and_Properties_support?= Message-ID: <160164131275.32230.18272600382995691588.asfpy@gitbox.apache.org> Date: Fri, 02 Oct 2020 12:21:52 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: rgannu commented on a change in pull request #4346: URL: https://github.com/apache/camel/pull/4346#discussion_r498786896 ########## File path: components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQConstants.java ########## @@ -16,42 +16,87 @@ */ package org.apache.camel.component.rabbitmq; -public final class RabbitMQConstants { +import java.util.Set; +import java.util.stream.Collectors; +import java.util.stream.Stream; + +public enum RabbitMQConstants { // TODO need to change the constant which is start with camel - public static final String ROUTING_KEY = "rabbitmq.ROUTING_KEY"; - public static final String EXCHANGE_OVERRIDE_NAME = "rabbitmq.EXCHANGE_OVERRIDE_NAME"; - public static final String EXCHANGE_NAME = "rabbitmq.EXCHANGE_NAME"; - public static final String CONTENT_TYPE = "rabbitmq.CONTENT_TYPE"; - public static final String PRIORITY = "rabbitmq.PRIORITY"; - public static final String DELIVERY_TAG = "rabbitmq.DELIVERY_TAG"; - public static final String REDELIVERY_TAG = "rabbitmq.REDELIVERY_TAG"; - public static final String CORRELATIONID = "rabbitmq.CORRELATIONID"; - public static final String MESSAGE_ID = "rabbitmq.MESSAGE_ID"; - public static final String DELIVERY_MODE = "rabbitmq.DELIVERY_MODE"; - public static final String USERID = "rabbitmq.USERID"; - public static final String CLUSTERID = "rabbitmq.CLUSTERID"; - public static final String REQUEST_TIMEOUT = "rabbitmq.REQUEST_TIMEOUT"; - public static final String REPLY_TO = "rabbitmq.REPLY_TO"; - public static final String CONTENT_ENCODING = "rabbitmq.CONTENT_ENCODING"; - public static final String TYPE = "rabbitmq.TYPE"; - public static final String EXPIRATION = "rabbitmq.EXPIRATION"; - public static final String TIMESTAMP = "rabbitmq.TIMESTAMP"; - public static final String APP_ID = "rabbitmq.APP_ID"; - public static final String REQUEUE = "rabbitmq.REQUEUE"; - public static final String MANDATORY = "rabbitmq.MANDATORY"; - public static final String IMMEDIATE = "rabbitmq.IMMEDIATE"; - public static final String RABBITMQ_DEAD_LETTER_EXCHANGE = "x-dead-letter-exchange"; - public static final String RABBITMQ_DEAD_LETTER_ROUTING_KEY = "x-dead-letter-routing-key"; - public static final String RABBITMQ_DIRECT_REPLY_EXCHANGE = ""; - public static final String RABBITMQ_DIRECT_REPLY_ROUTING_KEY = "amq.rabbitmq.reply-to"; - public static final String RABBITMQ_QUEUE_LENGTH_LIMIT_KEY = "x-max-length"; - public static final String RABBITMQ_QUEUE_MAX_PRIORITY_KEY = "x-max-priority"; - public static final String RABBITMQ_QUEUE_MESSAGE_TTL_KEY = "x-message-ttl"; - public static final String RABBITMQ_QUEUE_TTL_KEY = "x-expires"; - public static final String RABBITMQ_QUEUE_SINGLE_ACTIVE_CONSUMER_KEY = "x-single-active-consumer"; - - private RabbitMQConstants() { - // Constants class + ROUTING_KEY("rabbitmq_ROUTING_KEY", "The routing key that will be used when sending the message"), Review comment: Ok. Reverted to normal constants. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org