camel-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1526: CAMEL-14297: Introduce RouteBuilderConfigurer
Date Wed, 12 Aug 2020 07:43:52 GMT

ppalaga commented on a change in pull request #1526:
URL: https://github.com/apache/camel-quarkus/pull/1526#discussion_r469067913



##########
File path: integration-tests/core/src/test/java/org/apache/camel/quarkus/core/CoreTest.java
##########
@@ -33,12 +33,18 @@
 
 @QuarkusTest
 public class CoreTest {
+
     @Test
     public void testContainerLookupFromRegistry() {
         RestAssured.when().get("/test/registry/lookup-registry").then().body(is("true"));
         RestAssured.when().get("/test/registry/lookup-context").then().body(is("true"));
     }
 
+    @Test
+    public void testLookupRoutes() {
+        RestAssured.when().get("/test/routes/lookup-routes").then().body(is("true"));

Review comment:
       Comparing the list of routeIds here would make it easier to troubleshoot if something
goes wrong.
   ```suggestion
           RestAssured.when().get("/test/routes/lookup-routes").then().body(is("foo,bar"));
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message