camel-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [camel-k-runtime] davsclaus commented on a change in pull request #153: Support Knative broker/trigger model
Date Sun, 13 Oct 2019 07:40:39 GMT
davsclaus commented on a change in pull request #153: Support Knative broker/trigger model
URL: https://github.com/apache/camel-k-runtime/pull/153#discussion_r334266495
 
 

 ##########
 File path: camel-knative/camel-knative-http/src/main/java/org/apache/camel/component/knative/http/KnativeHttpProducer.java
 ##########
 @@ -83,12 +92,22 @@ public boolean process(Exchange exchange, AsyncCallback callback) {
         }
 
         for (Map.Entry<String, Object> entry : message.getHeaders().entrySet()) {
-            if (!endpoint.getHeaderFilterStrategy().applyFilterToCamelHeaders(entry.getKey(),
entry.getValue(), exchange)) {
+            if (!headerFilterStrategy.applyFilterToCamelHeaders(entry.getKey(), entry.getValue(),
exchange)) {
                 headers.add(entry.getKey(), entry.getValue().toString());
             }
         }
 
-        client.post(endpoint.getPort(), endpoint.getHost(), endpoint.getPath())
+        if (ObjectHelper.isEmpty(serviceDefinition.getHost())) {
+            exchange.setException(new CamelException("HTTP operation failed because host
is not defined"));
+            callback.done(true);
+
+            return false;
 
 Review comment:
   This is wrong it should be return true

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message