Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 344FA200C55 for ; Thu, 13 Apr 2017 13:02:59 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 32F7F160BA7; Thu, 13 Apr 2017 11:02:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7AFF1160B8B for ; Thu, 13 Apr 2017 13:02:58 +0200 (CEST) Received: (qmail 25263 invoked by uid 500); 13 Apr 2017 11:02:57 -0000 Mailing-List: contact commits-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list commits@camel.apache.org Received: (qmail 25254 invoked by uid 99); 13 Apr 2017 11:02:57 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Apr 2017 11:02:57 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 94296DFE2C; Thu, 13 Apr 2017 11:02:57 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: davsclaus@apache.org To: commits@camel.apache.org Date: Thu, 13 Apr 2017 11:02:57 -0000 Message-Id: <04c1491b5c714e8ea66c256ff2beedbe@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [1/2] camel git commit: OpenTracing: Change error to warn based on review comment archived-at: Thu, 13 Apr 2017 11:02:59 -0000 Repository: camel Updated Branches: refs/heads/master e269e10d4 -> e1d89ddbf OpenTracing: Change error to warn based on review comment Project: http://git-wip-us.apache.org/repos/asf/camel/repo Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/e1d89ddb Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/e1d89ddb Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/e1d89ddb Branch: refs/heads/master Commit: e1d89ddbf6028369fd3117ff648fc6f16a1786fe Parents: b5bdecd Author: Gary Brown Authored: Thu Apr 13 11:51:18 2017 +0100 Committer: Claus Ibsen Committed: Thu Apr 13 13:02:50 2017 +0200 ---------------------------------------------------------------------- .../org/apache/camel/opentracing/OpenTracingTracer.java | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/camel/blob/e1d89ddb/components/camel-opentracing/src/main/java/org/apache/camel/opentracing/OpenTracingTracer.java ---------------------------------------------------------------------- diff --git a/components/camel-opentracing/src/main/java/org/apache/camel/opentracing/OpenTracingTracer.java b/components/camel-opentracing/src/main/java/org/apache/camel/opentracing/OpenTracingTracer.java index f3d15d4..3ae9fc1 100644 --- a/components/camel-opentracing/src/main/java/org/apache/camel/opentracing/OpenTracingTracer.java +++ b/components/camel-opentracing/src/main/java/org/apache/camel/opentracing/OpenTracingTracer.java @@ -242,7 +242,8 @@ public class OpenTracingTracer extends ServiceSupport implements RoutePolicyFact managedSpan.deactivate(); } } catch (Throwable t) { - LOG.error("OpenTracing: Failed to capture tracing data", t); + // This exception is ignored + LOG.warn("OpenTracing: Failed to capture tracing data", t); } } @@ -283,7 +284,8 @@ public class OpenTracingTracer extends ServiceSupport implements RoutePolicyFact LOG.trace("OpenTracing: start server span=" + span); } } catch (Throwable t) { - LOG.error("OpenTracing: Failed to capture tracing data", t); + // This exception is ignored + LOG.warn("OpenTracing: Failed to capture tracing data", t); } } @@ -303,7 +305,8 @@ public class OpenTracingTracer extends ServiceSupport implements RoutePolicyFact LOG.warn("OpenTracing: could not find managed span for exchange=" + exchange); } } catch (Throwable t) { - LOG.error("OpenTracing: Failed to capture tracing data", t); + // This exception is ignored + LOG.warn("OpenTracing: Failed to capture tracing data", t); } } } @@ -327,7 +330,8 @@ public class OpenTracingTracer extends ServiceSupport implements RoutePolicyFact span.log(fields); } } catch (Throwable t) { - LOG.error("OpenTracing: Failed to capture tracing data", t); + // This exception is ignored + LOG.warn("OpenTracing: Failed to capture tracing data", t); } return message; }