Return-Path: X-Original-To: apmail-camel-commits-archive@www.apache.org Delivered-To: apmail-camel-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BF70618FC5 for ; Wed, 13 Jan 2016 14:24:30 +0000 (UTC) Received: (qmail 60599 invoked by uid 500); 13 Jan 2016 14:24:30 -0000 Delivered-To: apmail-camel-commits-archive@camel.apache.org Received: (qmail 60549 invoked by uid 500); 13 Jan 2016 14:24:30 -0000 Mailing-List: contact commits-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list commits@camel.apache.org Received: (qmail 60540 invoked by uid 99); 13 Jan 2016 14:24:30 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jan 2016 14:24:30 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 87959DFDCF; Wed, 13 Jan 2016 14:24:30 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: acosentino@apache.org To: commits@camel.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: camel git commit: CAMEL-9505: RabbitMQConsumer don't use Camel ExceptionHandler BEFORE requeing message Date: Wed, 13 Jan 2016 14:24:30 +0000 (UTC) Repository: camel Updated Branches: refs/heads/camel-2.16.x 02fd57d85 -> 0d82e68f6 CAMEL-9505: RabbitMQConsumer don't use Camel ExceptionHandler BEFORE requeing message Project: http://git-wip-us.apache.org/repos/asf/camel/repo Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/0d82e68f Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/0d82e68f Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/0d82e68f Branch: refs/heads/camel-2.16.x Commit: 0d82e68f6d9669b36ab642a5185bf1508f9047c9 Parents: 02fd57d Author: Andrea Cosentino Authored: Wed Jan 13 15:19:57 2016 +0100 Committer: Andrea Cosentino Committed: Wed Jan 13 15:22:01 2016 +0100 ---------------------------------------------------------------------- .../apache/camel/component/rabbitmq/RabbitMQConsumer.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/camel/blob/0d82e68f/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQConsumer.java ---------------------------------------------------------------------- diff --git a/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQConsumer.java b/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQConsumer.java index 3a5a4ea..a2b4f41 100644 --- a/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQConsumer.java +++ b/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQConsumer.java @@ -223,7 +223,11 @@ public class RabbitMQConsumer extends DefaultConsumer { } else { msg = exchange.getIn(); } - + + if (exchange.getException() != null) { + getExceptionHandler().handleException("Error processing exchange", exchange, exchange.getException()); + } + if (!exchange.isFailed()) { // processing success if (sendReply && exchange.getPattern().isOutCapable()) { @@ -253,9 +257,6 @@ public class RabbitMQConsumer extends DefaultConsumer { channel.basicAck(deliveryTag, false); } } else { - if (exchange.getException() != null) { - getExceptionHandler().handleException("Error processing exchange", exchange, exchange.getException()); - } boolean isRequeueHeaderSet = msg.getHeader(RabbitMQConstants.REQUEUE, false, boolean.class); // processing failed, then reject and handle the exception if (deliveryTag != 0 && !consumer.endpoint.isAutoAck()) {