Return-Path: X-Original-To: apmail-camel-commits-archive@www.apache.org Delivered-To: apmail-camel-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 85978F67F for ; Tue, 16 Apr 2013 13:41:11 +0000 (UTC) Received: (qmail 68344 invoked by uid 500); 16 Apr 2013 13:41:11 -0000 Delivered-To: apmail-camel-commits-archive@camel.apache.org Received: (qmail 68306 invoked by uid 500); 16 Apr 2013 13:41:11 -0000 Mailing-List: contact commits-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list commits@camel.apache.org Received: (qmail 68299 invoked by uid 99); 16 Apr 2013 13:41:11 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Apr 2013 13:41:11 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Apr 2013 13:41:08 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id A212323888FE; Tue, 16 Apr 2013 13:40:47 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1468410 - in /camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor: ActivityMonitorEngine.java BamProcessorSupport.java JpaBamProcessorSupport.java Date: Tue, 16 Apr 2013 13:40:47 -0000 To: commits@camel.apache.org From: davsclaus@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20130416134047.A212323888FE@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: davsclaus Date: Tue Apr 16 13:40:47 2013 New Revision: 1468410 URL: http://svn.apache.org/r1468410 Log: Reduce logging noise in camel-bam Modified: camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/ActivityMonitorEngine.java camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/BamProcessorSupport.java camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/JpaBamProcessorSupport.java Modified: camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/ActivityMonitorEngine.java URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/ActivityMonitorEngine.java?rev=1468410&r1=1468409&r2=1468410&view=diff ============================================================================== --- camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/ActivityMonitorEngine.java (original) +++ camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/ActivityMonitorEngine.java Tue Apr 16 13:40:47 2013 @@ -94,11 +94,11 @@ public class ActivityMonitorEngine exten try { Thread.sleep(timeToSleep); } catch (InterruptedException e) { - LOG.debug("Caught: " + e, e); + // ignore } } } catch (Exception e) { - LOG.error("Caught: " + e, e); + LOG.warn("Error during running ActivityMonitorEngine. This exception is ignored.", e); } } } @@ -110,9 +110,9 @@ public class ActivityMonitorEngine exten public Object doInJpa(EntityManager entityManager) throws PersistenceException { // let's try locking the object first if (isUseLocking()) { - LOG.info("Attempting to lock: " + activityState); + LOG.debug("Attempting to lock: {}", activityState); entityManager.lock(activityState, LockModeType.WRITE); - LOG.info("Grabbed lock: " + activityState); + LOG.debug("Grabbed lock: {}", activityState); } try { Modified: camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/BamProcessorSupport.java URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/BamProcessorSupport.java?rev=1468410&r1=1468409&r2=1468410&view=diff ============================================================================== --- camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/BamProcessorSupport.java (original) +++ camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/BamProcessorSupport.java Tue Apr 16 13:40:47 2013 @@ -82,7 +82,7 @@ public abstract class BamProcessorSuppor try { Thread.sleep(retrySleep); } catch (InterruptedException e) { - LOG.debug("Caught: " + e, e); + // ignore } } try { @@ -104,11 +104,11 @@ public abstract class BamProcessorSuppor } }); if (i > 1) { - LOG.info("Attempt {} worked!", i); + LOG.debug("Attempt {} worked!", i); } return; } catch (Exception e) { - LOG.warn("Failed to complete transaction: " + e, e); + LOG.warn("Failed to complete transaction. This exception is ignored.", e); } } } @@ -147,7 +147,7 @@ public abstract class BamProcessorSuppor protected void onError(TransactionStatus status, Exception e) throws RuntimeCamelException { status.setRollbackOnly(); - LOG.error("Caught: " + e, e); + LOG.warn("Caught: " + e, e); throw wrapRuntimeCamelException(e); } Modified: camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/JpaBamProcessorSupport.java URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/JpaBamProcessorSupport.java?rev=1468410&r1=1468409&r2=1468410&view=diff ============================================================================== --- camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/JpaBamProcessorSupport.java (original) +++ camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/JpaBamProcessorSupport.java Tue Apr 16 13:40:47 2013 @@ -115,7 +115,7 @@ public class JpaBamProcessorSupport e protected T loadEntity(Exchange exchange, Object key) throws Exception { LOCK.lock(); try { - LOG.info(">> LoadEntity call"); + LOG.trace("LoadEntity call"); T entity = findEntityByCorrelationKey(key); if (entity == null) { entity = createEntity(exchange, key); @@ -127,7 +127,7 @@ public class JpaBamProcessorSupport e // Now we must flush to avoid concurrent updates clashing trying to // insert the same row - LOG.debug("About to flush on entity: " + entity + " with key: " + key); + LOG.debug("About to flush on entity: {} with key: {}", entity, key); template.flush(); } return entity; @@ -157,7 +157,7 @@ public class JpaBamProcessorSupport e Method getter = IntrospectionSupport.getPropertyGetter(getEntityType(), getKeyPropertyName()); return getter.getReturnType(); } catch (NoSuchMethodException e) { - LOG.warn("no such getter for: " + getKeyPropertyName() + " on " + getEntityType() + ". Reason: " + e, e); + LOG.warn("no such getter for: " + getKeyPropertyName() + " on " + getEntityType() + ". This exception will be ignored.", e); return null; } }