camel-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davscl...@apache.org
Subject svn commit: r1361921 - in /camel/branches/camel-2.9.x: ./ components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/PersistentQueueReplyManager.java
Date Mon, 16 Jul 2012 07:07:51 GMT
Author: davsclaus
Date: Mon Jul 16 07:07:51 2012
New Revision: 1361921

URL: http://svn.apache.org/viewvc?rev=1361921&view=rev
Log:
CAMEL-5444: Log a WARN if shared reply queues are in use as they are slow, to make this stand
out to the Camel end users, so they know about this and can reconfigured for a better solution
if that is possible for their use-case.

Modified:
    camel/branches/camel-2.9.x/   (props changed)
    camel/branches/camel-2.9.x/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/PersistentQueueReplyManager.java

Propchange: camel/branches/camel-2.9.x/
------------------------------------------------------------------------------
  Merged /camel/trunk:r1361919
  Merged /camel/branches/camel-2.10.x:r1361920

Propchange: camel/branches/camel-2.9.x/
------------------------------------------------------------------------------
Binary property 'svnmerge-integrated' - no diff available.

Modified: camel/branches/camel-2.9.x/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/PersistentQueueReplyManager.java
URL: http://svn.apache.org/viewvc/camel/branches/camel-2.9.x/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/PersistentQueueReplyManager.java?rev=1361921&r1=1361920&r2=1361921&view=diff
==============================================================================
--- camel/branches/camel-2.9.x/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/PersistentQueueReplyManager.java
(original)
+++ camel/branches/camel-2.9.x/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/PersistentQueueReplyManager.java
Mon Jul 16 07:07:51 2012
@@ -145,6 +145,9 @@ public class PersistentQueueReplyManager
                 answer.setCacheLevel(DefaultMessageListenerContainer.CACHE_SESSION);
                 log.debug("Using shared queue: " + endpoint.getReplyTo() + " with dynamic
message selector as reply listener: " + answer);
             }
+            // shared is not as fast as temporary or exclusive, so log this so the end user
may be aware of this
+            log.warn("{} is using a shared reply queue, which is not as fast as alternatives."
+                    + " See more detail at the section 'Request-reply over JMS' at http://camel.apache.org/jms",
endpoint);
         } else if (ReplyToType.Exclusive == type) {
             answer = new ExclusivePersistentQueueMessageListenerContainer();
             // must use cache level consumer for exclusive as there is no message selector



Mime
View raw message