Return-Path: X-Original-To: apmail-camel-commits-archive@www.apache.org Delivered-To: apmail-camel-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EC4A2DA06 for ; Fri, 29 Jun 2012 08:19:13 +0000 (UTC) Received: (qmail 15280 invoked by uid 500); 29 Jun 2012 08:19:13 -0000 Delivered-To: apmail-camel-commits-archive@camel.apache.org Received: (qmail 15160 invoked by uid 500); 29 Jun 2012 08:19:11 -0000 Mailing-List: contact commits-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list commits@camel.apache.org Received: (qmail 15129 invoked by uid 99); 29 Jun 2012 08:19:10 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Jun 2012 08:19:10 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Jun 2012 08:19:08 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 5258A238899C; Fri, 29 Jun 2012 08:18:47 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1355261 - /camel/trunk/components/camel-mina/src/main/java/org/apache/camel/component/mina/MinaProducer.java Date: Fri, 29 Jun 2012 08:18:46 -0000 To: commits@camel.apache.org From: davsclaus@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20120629081847.5258A238899C@eris.apache.org> Author: davsclaus Date: Fri Jun 29 08:18:45 2012 New Revision: 1355261 URL: http://svn.apache.org/viewvc?rev=1355261&view=rev Log: CAMEL-5405: Ensure mina producer always disconnects if configured to do so, even for timeouts when doing request/reply. Modified: camel/trunk/components/camel-mina/src/main/java/org/apache/camel/component/mina/MinaProducer.java Modified: camel/trunk/components/camel-mina/src/main/java/org/apache/camel/component/mina/MinaProducer.java URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-mina/src/main/java/org/apache/camel/component/mina/MinaProducer.java?rev=1355261&r1=1355260&r2=1355261&view=diff ============================================================================== --- camel/trunk/components/camel-mina/src/main/java/org/apache/camel/component/mina/MinaProducer.java (original) +++ camel/trunk/components/camel-mina/src/main/java/org/apache/camel/component/mina/MinaProducer.java Fri Jun 29 08:18:45 2012 @@ -73,6 +73,15 @@ public class MinaProducer extends Defaul } public void process(Exchange exchange) throws Exception { + try { + doProcess(exchange); + } finally { + // ensure we always disconnect if configured + maybeDisconnectOnDone(exchange); + } + } + + protected void doProcess(Exchange exchange) throws Exception { if (session == null && !lazySessionCreation) { throw new IllegalStateException("Not started yet!"); } @@ -141,6 +150,12 @@ public class MinaProducer extends Defaul } } } + } + + protected void maybeDisconnectOnDone(Exchange exchange) { + if (session == null) { + return; + } // should session be closed after complete? Boolean close;