camel-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davscl...@apache.org
Subject svn commit: r1153816 - in /camel/trunk/camel-core/src/main/java/org/apache/camel: builder/AdviceWithRouteBuilder.java model/RouteDefinition.java
Date Thu, 04 Aug 2011 09:55:19 GMT
Author: davsclaus
Date: Thu Aug  4 09:55:18 2011
New Revision: 1153816

URL: http://svn.apache.org/viewvc?rev=1153816&view=rev
Log:
CAMEL-4296: Added javadoc note about usage of adviceWith

Modified:
    camel/trunk/camel-core/src/main/java/org/apache/camel/builder/AdviceWithRouteBuilder.java
    camel/trunk/camel-core/src/main/java/org/apache/camel/model/RouteDefinition.java

Modified: camel/trunk/camel-core/src/main/java/org/apache/camel/builder/AdviceWithRouteBuilder.java
URL: http://svn.apache.org/viewvc/camel/trunk/camel-core/src/main/java/org/apache/camel/builder/AdviceWithRouteBuilder.java?rev=1153816&r1=1153815&r2=1153816&view=diff
==============================================================================
--- camel/trunk/camel-core/src/main/java/org/apache/camel/builder/AdviceWithRouteBuilder.java
(original)
+++ camel/trunk/camel-core/src/main/java/org/apache/camel/builder/AdviceWithRouteBuilder.java
Thu Aug  4 09:55:18 2011
@@ -27,6 +27,10 @@ import org.apache.camel.util.ObjectHelpe
 /**
  * A {@link RouteBuilder} which has extended capabilities when using
  * the <a href="http://camel.apache.org/advicewith.html">advice with</a> feature.
+ * <p/>
+ * <b>Important:</b> It is recommended to only advice a given route once (you
can of course advice multiple routes).
+ * If you do it multiple times, then it may not work as expected, especially when any kind
of error handling is involved.
+ * The Camel team plan for Camel 3.0 to support this as internal refactorings in the routing
engine is needed to support this properly.
  *
  * @see org.apache.camel.model.RouteDefinition#adviceWith(org.apache.camel.CamelContext,
RouteBuilder)
  */

Modified: camel/trunk/camel-core/src/main/java/org/apache/camel/model/RouteDefinition.java
URL: http://svn.apache.org/viewvc/camel/trunk/camel-core/src/main/java/org/apache/camel/model/RouteDefinition.java?rev=1153816&r1=1153815&r2=1153816&view=diff
==============================================================================
--- camel/trunk/camel-core/src/main/java/org/apache/camel/model/RouteDefinition.java (original)
+++ camel/trunk/camel-core/src/main/java/org/apache/camel/model/RouteDefinition.java Thu Aug
 4 09:55:18 2011
@@ -183,6 +183,10 @@ public class RouteDefinition extends Pro
     /**
      * Advices this route with the route builder.
      * <p/>
+     * <b>Important:</b> It is recommended to only advice a given route once
(you can of course advice multiple routes).
+     * If you do it multiple times, then it may not work as expected, especially when any
kind of error handling is involved.
+     * The Camel team plan for Camel 3.0 to support this as internal refactorings in the
routing engine is needed to support this properly.
+     * <p/>
      * You can use a regular {@link RouteBuilder} but the specialized {@link org.apache.camel.builder.AdviceWithRouteBuilder}
      * has additional features when using the <a href="http://camel.apache.org/advicewith.html">advice
with</a> feature.
      * We therefore suggest you to use the {@link org.apache.camel.builder.AdviceWithRouteBuilder}.



Mime
View raw message