camel-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davscl...@apache.org
Subject svn commit: r647657 - in /activemq/camel/trunk/camel-core/src: main/java/org/apache/camel/model/ProcessorType.java test/java/org/apache/camel/issues/InterceptorLogTest.java
Date Mon, 14 Apr 2008 04:21:23 GMT
Author: davsclaus
Date: Sun Apr 13 21:21:20 2008
New Revision: 647657

URL: http://svn.apache.org/viewvc?rev=647657&view=rev
Log:
CAMEL-461 - Fixed intercept logging all steps failing due proceed not working. Applied patch
from Jonathan with thanks.

Modified:
    activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/model/ProcessorType.java
    activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/issues/InterceptorLogTest.java

Modified: activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/model/ProcessorType.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/model/ProcessorType.java?rev=647657&r1=647656&r2=647657&view=diff
==============================================================================
--- activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/model/ProcessorType.java
(original)
+++ activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/model/ProcessorType.java
Sun Apr 13 21:21:20 2008
@@ -50,7 +50,6 @@
 import org.apache.camel.processor.MulticastProcessor;
 import org.apache.camel.processor.Pipeline;
 import org.apache.camel.processor.RecipientList;
-import org.apache.camel.processor.SetHeaderProcessor;
 import org.apache.camel.processor.aggregate.AggregationCollection;
 import org.apache.camel.processor.aggregate.AggregationStrategy;
 import org.apache.camel.processor.idempotent.IdempotentConsumer;
@@ -73,11 +72,7 @@
     private LinkedList<Block> blocks = new LinkedList<Block>();
     private ProcessorType<? extends ProcessorType> parent;
 
-    // else to use an
-    // optional
-    // attribute in
-    // JAXB2
-
+    // else to use an optional attribute in JAXB2
     public abstract List<ProcessorType<?>> getOutputs();
 
 
@@ -880,6 +875,11 @@
                 break;
             }
         }
+        
+        if (this instanceof InterceptType) {
+        	proceed = ((InterceptType) this).getProceed();
+        }
+        
         if (proceed == null) {
             throw new IllegalArgumentException("Cannot use proceed() without being within
an intercept() block");
         }

Modified: activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/issues/InterceptorLogTest.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/issues/InterceptorLogTest.java?rev=647657&r1=647656&r2=647657&view=diff
==============================================================================
--- activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/issues/InterceptorLogTest.java
(original)
+++ activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/issues/InterceptorLogTest.java
Sun Apr 13 21:21:20 2008
@@ -11,7 +11,9 @@
 
     public void testInterceptor() throws Exception {
         MockEndpoint mock = getMockEndpoint("mock:result");
-        mock.expectedMessageCount(1);
+        // TODO: we should only expect 1 message, but seda queues can sometimes send multiple
+        mock.expectedMinimumMessageCount(1);
+        mock.expectedBodiesReceived("Hello World");
 
         template.sendBody("seda:foo", "Hello World");
 
@@ -21,9 +23,9 @@
     protected RouteBuilder createRouteBuilder() throws Exception {
         return new RouteBuilder() {
             public void configure() throws Exception {
-                // lets log all steps in all routes
-                // TODO: this does not work as expected. if enabled the exchange is not routed
to seda:bar
-                //intercept().to("log:foo");
+                // lets log all steps in all routes (must use proceed to let the exchange
gots by its
+                // normal route path instead of swalling it here by our interception
+                intercept().to("log:foo").proceed();
 
                 from("seda:foo").to("seda:bar");
                 from("seda:bar").to("mock:result");



Mime
View raw message