Return-Path: X-Original-To: apmail-calcite-dev-archive@www.apache.org Delivered-To: apmail-calcite-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D56FD186BE for ; Thu, 9 Jul 2015 18:12:09 +0000 (UTC) Received: (qmail 60709 invoked by uid 500); 9 Jul 2015 18:12:09 -0000 Delivered-To: apmail-calcite-dev-archive@calcite.apache.org Received: (qmail 60658 invoked by uid 500); 9 Jul 2015 18:12:09 -0000 Mailing-List: contact dev-help@calcite.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@calcite.incubator.apache.org Delivered-To: mailing list dev@calcite.incubator.apache.org Received: (qmail 60647 invoked by uid 99); 9 Jul 2015 18:12:09 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jul 2015 18:12:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 40504D353C for ; Thu, 9 Jul 2015 18:12:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.452 X-Spam-Level: * X-Spam-Status: No, score=1.452 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.329, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id g0BCrORzefpn for ; Thu, 9 Jul 2015 18:11:57 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id B02D743A5B for ; Thu, 9 Jul 2015 18:11:56 +0000 (UTC) Received: (qmail 59060 invoked by uid 99); 9 Jul 2015 18:11:56 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jul 2015 18:11:56 +0000 Received: from mail-ob0-f180.google.com (mail-ob0-f180.google.com [209.85.214.180]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id DD8BA1A01DC for ; Thu, 9 Jul 2015 18:11:55 +0000 (UTC) Received: by obdbs4 with SMTP id bs4so176945286obd.3 for ; Thu, 09 Jul 2015 11:11:54 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.202.76.12 with SMTP id z12mr8311119oia.16.1436465514784; Thu, 09 Jul 2015 11:11:54 -0700 (PDT) Received: by 10.202.115.15 with HTTP; Thu, 9 Jul 2015 11:11:54 -0700 (PDT) In-Reply-To: References: Date: Thu, 9 Jul 2015 11:11:54 -0700 Message-ID: Subject: Re: Possible minor issue using example/csv ? From: Julian Hyde To: dev@calcite.incubator.apache.org Content-Type: text/plain; charset=UTF-8 I have checked in a fix for https://issues.apache.org/jira/browse/CALCITE-752 and have also verified that example/csv/sqlline.bat works under Windows. Julian On Tue, Jul 7, 2015 at 10:50 PM, George Spofford wrote: > I should have checked JIRA first, sorry! > > On Tue, Jul 7, 2015 at 10:10 PM, Jinfeng Ni wrote: > >> I filed Calcite-752 for the sqlline issue in example/csv module last month, >> and provide a patch for it. >> >> https://issues.apache.org/jira/browse/CALCITE-752 >> >> >> >> On Tue, Jul 7, 2015 at 8:55 PM, Julian Hyde wrote: >> >> > I see that I fixed core/pom.xml in >> > https://issues.apache.org/jira/browse/CALCITE-692 but did not fix >> > example/csv/pom.xml. >> > >> > It looks like you've completed the task I started. And your "hack" to >> > force maven to ignore warnings is exactly right. >> > >> > So I was wrong, it wasn't a windows problem. I'm still going to check >> > on Windows before I commit. >> > >> > Julian >> > >> > >> > On Tue, Jul 7, 2015 at 8:17 PM, Julian Hyde wrote: >> > > Probably a windows issue. >> > > >> > > Are you running the sqlline.bat in root or example/csv? >> > > >> > > Run 'mvn clean' then 'mvn install' then run sqlline.bat again. >> > > >> > > If you have cygwin, try running sqlline.sh instead. >> > > >> > > Regardless, please log a jira case. I will try to reproduce on a >> > > windows VM tomorrow. >> > > >> > > Julian >> > > >> > > >> > > On Tue, Jul 7, 2015 at 7:41 PM, George Spofford > > >> > wrote: >> > >> Hi there and sorry if this is well-known to the community. I'm >> starting >> > to >> > >> try to familiarize myself with Calcite (years too late!). Downloading >> > the >> > >> 1.4 from the github mirror today and building, I follow the steps on >> > >> https://calcite.incubator.apache.org/docs/tutorial.html >> > >> >> > >> When I cd'd to the example/csv directory and run sqlline.bat, I get >> the >> > >> following: >> > >> >> > >> Error: Could not find or load main class sqlline.SqlLine >> > >> >> > >> >> > >> Turns out that sqlline is not a dependency in this POM. >> > >> >> > >> sh-4.1$ mvn dependency:tree >> > >> [INFO] Scanning for projects... >> > >> [INFO] >> > >> [INFO] Using the builder >> > >> >> > >> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder >> > >> with a thread >> > >> count of 1 >> > >> [INFO] >> > >> [INFO] >> > >> >> ------------------------------------------------------------------------ >> > >> [INFO] Building Calcite Example CSV 1.4.0-incubating-SNAPSHOT >> > >> [INFO] >> > >> >> ------------------------------------------------------------------------ >> > >> [INFO] >> > >> [INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ >> > >> calcite-example-csv --- >> > >> [INFO] >> > org.apache.calcite:calcite-example-csv:jar:1.4.0-incubating-SNAPSHOT >> > >> [INFO] +- >> > >> org.apache.calcite:calcite-core:jar:1.4.0-incubating-SNAPSHOT:compile >> > >> [INFO] | +- >> > >> >> org.apache.calcite:calcite-avatica:jar:1.4.0-incubating-SNAPSHOT:compile >> > >> [INFO] | +- commons-dbcp:commons-dbcp:jar:1.4:compile >> > >> [INFO] | | \- commons-pool:commons-pool:jar:1.5.4:compile >> > >> [INFO] | +- >> > >> com.fasterxml.jackson.core:jackson-annotations:jar:2.1.1:compile >> > >> [INFO] | +- com.google.code.findbugs:jsr305:jar:1.3.9:compile >> > >> [INFO] | +- net.hydromatic:eigenbase-properties:jar:1.1.5:compile >> > >> [INFO] | +- org.codehaus.janino:janino:jar:2.7.6:compile >> > >> [INFO] | +- org.codehaus.janino:commons-compiler:jar:2.7.6:compile >> > >> [INFO] | \- >> > >> org.pentaho:pentaho-aggdesigner-algorithm:jar:5.1.5-jhyde:compile >> > >> [INFO] | +- commons-lang:commons-lang:jar:2.4:compile >> > >> [INFO] | \- commons-logging:commons-logging:jar:1.1.3:compile >> > >> [INFO] +- >> > >> >> org.apache.calcite:calcite-linq4j:jar:1.4.0-incubating-SNAPSHOT:compile >> > >> [INFO] +- com.fasterxml.jackson.core:jackson-core:jar:2.1.1:compile >> > >> [INFO] +- >> com.fasterxml.jackson.core:jackson-databind:jar:2.1.1:compile >> > >> [INFO] +- com.google.guava:guava:jar:14.0.1:compile >> > >> [INFO] +- junit:junit:jar:4.11:test >> > >> [INFO] | \- org.hamcrest:hamcrest-core:jar:1.3:test >> > >> [INFO] +- net.sf.opencsv:opencsv:jar:2.3:compile >> > >> [INFO] \- org.apache.commons:commons-lang3:jar:3.2:compile >> > >> [INFO] >> > >> >> ------------------------------------------------------------------------ >> > >> >> > >> >> > >> To add it, I hacked the POM to NOT fail on warnings, since sqlline is >> > not >> > >> otherwise a dependency for anything in the project. >> > >> >> > >> >> > >> >> > >> >> > >> >> > >> org.apache.maven.plugins >> > >> maven-dependency-plugin >> > >> 2.10 >> > >> >> > >> >> > >> analyze >> > >> >> > >> analyze-only >> > >> >> > >> >> > >> false >> > >> >> > >> >> > >> >> > >> >> > >> >> > >> >> > >> >> > >> Then, everything seems to work fine. >> > >> >> > >> My build environment for Calcite is: >> > >> >> > >> Windows 7 Pro SP1 x64, 16 GB RAM >> > >> Calcite 1.4 (commit 03111d2b680c4f4eb4886d60cab9beebd1c7bdcb) >> > >> Maven 3.2.1 >> > >> JDK 1.8.0_45 >> > >> >> > >> Thank you for any assistance! >> > >> >> > >> George Spofford >> > >>