Return-Path: X-Original-To: apmail-calcite-dev-archive@www.apache.org Delivered-To: apmail-calcite-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7B1D41819D for ; Fri, 24 Jul 2015 18:32:19 +0000 (UTC) Received: (qmail 79675 invoked by uid 500); 24 Jul 2015 18:32:19 -0000 Delivered-To: apmail-calcite-dev-archive@calcite.apache.org Received: (qmail 79615 invoked by uid 500); 24 Jul 2015 18:32:19 -0000 Mailing-List: contact dev-help@calcite.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@calcite.incubator.apache.org Delivered-To: mailing list dev@calcite.incubator.apache.org Received: (qmail 79603 invoked by uid 99); 24 Jul 2015 18:32:19 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Jul 2015 18:32:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id AB46ED759C for ; Fri, 24 Jul 2015 18:32:18 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.099 X-Spam-Level: X-Spam-Status: No, score=-0.099 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 2LkUqblCEqbM for ; Fri, 24 Jul 2015 18:32:13 +0000 (UTC) Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTPS id D8B632156D for ; Fri, 24 Jul 2015 18:32:12 +0000 (UTC) Received: by wibud3 with SMTP id ud3so75428752wib.1 for ; Fri, 24 Jul 2015 11:32:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=LqmHdQrU8IHB1UH+VKbiEqUylM/ueUTdvEXimquzpQo=; b=R119TpuuQFGnWFfowoszz+vlfR3HA5KL/Oyyo0vnjK17Np31toEMusghW5O1zk4ear y8QPIsBfq3XdWJOX3K0C9iWsXrQY8gpr/6It0REYukLbNVBUSz19TnHvF05+/dTIX5xG yZPS+LYk0NkuhoHQr4CBfKuA/vJVbFoUopULCMDEkPJIX2qe3vXXmLbmPDqe0ooAqfHM gkj0GddR1kLb/zi2Pu8xbDofP3GwNhJmZPUb0rAOwNtsbbzpEKFGxFKUH7wr6T6WwfcF PZW67ZxK5dCxCsk2FJ95kaHzAcRLwdnjXnafQbbO3r7lqWeAzDN41uwtzqWq9OwMtthg 4RHw== MIME-Version: 1.0 X-Received: by 10.180.210.234 with SMTP id mx10mr10091538wic.42.1437762731666; Fri, 24 Jul 2015 11:32:11 -0700 (PDT) Received: by 10.27.176.157 with HTTP; Fri, 24 Jul 2015 11:32:11 -0700 (PDT) In-Reply-To: <19C65F50-0CAA-4D95-9087-AA43B8BF9BC0@apache.org> References: <19C65F50-0CAA-4D95-9087-AA43B8BF9BC0@apache.org> Date: Fri, 24 Jul 2015 21:32:11 +0300 Message-ID: Subject: Re: Unclear hard-coding in planner and other parts of source code From: Vladimir Sitnikov To: "dev@calcite.incubator.apache.org" Content-Type: text/plain; charset=UTF-8 I'm not sure if that was considered, but the good part with if (true)/if (false) is the "if-commented" code is compiled and it works for "find usages", etc use-cases. It might give an insight "what works and what does not". "If it doesn't worth compiling, it doesn't worth maintaining (or don't check in commented out code)" via https://twitter.com/mariofusco/status/378068886081769472 from http://www.codemesh.io/codemesh2013/slides/viktor-klang.pdf Vladimir