Mailing-List: contact dev-help@calcite.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@calcite.incubator.apache.org
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\))
Subject: Re: The art of the commit comment
From: Julian Hyde <jhyde@apache.org>
In-Reply-To: 
 <CAKa9qD=1PD3-Rb57S0Kp7ahG6MuXv--D4gYfyHJHO=dcQJBW6Q@mail.gmail.com>
Date: Thu, 30 Jul 2015 19:49:03 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <37859C12-1D22-4FA0-B408-A938865AFDA7@apache.org>
References: 
 <CAPSgeES9H8MmzZ_vKJdf0TFLxzOD6YTKzLG0tqCNm553F4PPbQ@mail.gmail.com>
 <CAK55V=JBTgo0Y1DUW0Jjw5giwY8WUWbCmq0dXPm8xpppoXt5=Q@mail.gmail.com>
 <CAB=Je-HtoNbKwMS=ocOwVmMkYH6eGDDTKrisdCNL3PokRRUMmQ@mail.gmail.com>
 <C2E56C6D-E087-47C8-A785-5A9F3C8F5FEF@apache.org>
 <CAKa9qDkAUK_ftnH=2ofhhHuhgLbwE-UYHwq3Q5FhmKwRYqDjRw@mail.gmail.com>
 <B56D8913-E40E-40C7-B919-19ACE433CD45@apache.org>
 <CAKa9qD=1PD3-Rb57S0Kp7ahG6MuXv--D4gYfyHJHO=dcQJBW6Q@mail.gmail.com>
To: dev@calcite.incubator.apache.org

The committer has to edit the commit already, to add the =E2=80=9CClose =
apache/incubator-calcite#=E2=80=A6=E2=80=9D line. And quite often to =
rebase.

> On Jul 30, 2015, at 7:40 PM, Jacques Nadeau <jacques@apache.org> =
wrote:
>=20
> My goal is to avoid the expectation that a committer should be =
manually
> editing every commit.  Ideally we should get to a point where that is
> unnecessary.  Proposed patches/pull requests should be mergeable as =
is.
>=20
> Looking at both git log and github [1], an author is given clear =
credit
> when different than committer.  I think the best type of credit.  It =
is the
> way people's github profiles get associated with their work.  We =
should
> require commits to have author tags to provide maximum recognition to
> contributors.
>=20
> [1]
> =
https://github.com/apache/drill/commit/a219f8784c55ce3bc15b9bb3a19d7b33e40=
21c00
>=20
> (note how Hsuan is given credit even though Parth is committer)
>=20
> On Thu, Jul 30, 2015 at 7:31 PM, Julian Hyde <jhyde@apache.org> wrote:
>=20
>> Not necessary, but where=E2=80=99s the harm in giving contributors =
obvious credit?
>>=20
>> (The change history in
>> http://calcite.incubator.apache.org/docs/history.html <
>> http://calcite.incubator.apache.org/docs/history.html> is culled from =
the
>> git log, with just a little massaging to convert jira case numbers =
into
>> links, so contributors get called out there too.)
>>=20
>>> On Jul 30, 2015, at 6:13 PM, Jacques Nadeau <jacques@apache.org> =
wrote:
>>>=20
>>> I don't follow.  If the author tag in the commit is correct, why is =
it
>>> necessary to also add it in parentheses?
>>>=20
>>> On Thu, Jul 30, 2015 at 11:35 AM, Julian Hyde <jhyde@apache.org> =
wrote:
>>>=20
>>>> I agree with what Vladimir and Jinfeng have said.
>>>>=20
>>>> We should make it clear that we prefer contributions via pull =
request
>> over
>>>> patches. Then the authorship is already in the contribution.
>>>>=20
>>>> But if the contribution comes via a patch, I like Vladimir=E2=80=99s =
suggestion
>> to
>>>> use use =E2=80=9Cgit =E2=80=94amend =E2=80=94author=E2=80=9D.
>>>>=20
>>>> We had a similar discussion a few months back. James Taylor =
suggested[1]
>>>> adding the author=E2=80=99s name in parentheses, which is what they =
do in
>> Phoenix
>>>> and HBase. I still think that is the right policy. Even though it =
is
>>>> redundant, it gives people credit, and that helps to build =
community.
>>>>=20
>>>> Julian
>>>>=20
>>>> [1]
>>>>=20
>> =
http://mail-archives.apache.org/mod_mbox/calcite-dev/201412.mbox/%3CCAAF1J=
djW2psSPLEGyM3YA_bCTVcNWTvNiwLHpL-CJ4-CFy-mbA@mail.gmail.com%3E
>>>> <
>>>>=20
>> =
http://mail-archives.apache.org/mod_mbox/calcite-dev/201412.mbox/%3CCAAF1J=
djW2psSPLEGyM3YA_bCTVcNWTvNiwLHpL-CJ4-CFy-mbA@mail.gmail.com%3E
>>>>>=20
>>>>=20
>>>>=20
>>=20
>>=20