calcite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesus Camachorodriguez <jcamachorodrig...@hortonworks.com>
Subject Re: 1.4.0-SNAPSHOT available, MASTER closed, please try it out
Date Wed, 29 Jul 2015 21:02:37 GMT
Thanks for fixing it so quickly Julian.

Sure, I'd like to do that. Is the new SNAPSHOT with the new fixes already
created?

--
Jesús


On 7/29/15, 10:55 PM, "Julian Hyde" <jhyde@apache.org> wrote:

>The fix is checked in. Can you restart the Hive tests and let us know
>when they have passed? Or maybe you don’t think it necessary to run the
>Hive tests?
>
>Julian
>
>
>> On Jul 29, 2015, at 11:10 AM, Jesus Camachorodriguez
>><jcamachorodriguez@hortonworks.com> wrote:
>> 
>> Thanks a lot Julian.
>> 
>> I'm checking it right now; I'll update the JIRA case when I'm done.
>> 
>> 
>> 
>> On 7/29/15, 7:43 PM, "Julian Hyde" <jhyde@apache.org> wrote:
>> 
>>> Jesus, I have modified
>>> https://issues.apache.org/jira/browse/CALCITE-821 with a suggested
>>> patch. Can you see whether it works?
>>> 
>>> On Wed, Jul 29, 2015 at 9:49 AM, Julian Hyde <jhyde@apache.org> wrote:
>>>> I'm looking into 821 also. You're right that it was caused by the edit
>>>> to Frameworks.java in the fix to
>>>> https://issues.apache.org/jira/browse/CALCITE-748. Not sure why that
>>>> change was made, I'm pretty sure it was for a good reason.
>>>> 
>>>> On Wed, Jul 29, 2015 at 12:58 AM, Jesus Camachorodriguez
>>>> <jcamachorodriguez@hortonworks.com> wrote:
>>>>> I've finally been able to trigger a Hive QA run. I have logged
>>>>> CALCITE-821
>>>>> which is making all our tests fail. We will be checking into that
>>>>> today.
>>>>> 
>>>>> Thanks,
>>>>> Jesús
>>>>> 
>>>>> 
>>>>> 
>>>>> On 7/29/15, 7:27 AM, "Jacques Nadeau" <jacques@apache.org> wrote:
>>>>> 
>>>>>> Ok.  Will do.
>>>>>> 
>>>>>> On Tue, Jul 28, 2015 at 10:15 PM, Julian Hyde <jhyde@apache.org>
>>>>>>wrote:
>>>>>> 
>>>>>>> Can you please take a look at 741, 743, Jacques. They're best
done
>>>>>>> while you're actually rolling a release.
>>>>>>> 
>>>>>>> On Tue, Jul 28, 2015 at 9:49 PM, Jacques Nadeau
>>>>>>><jacques@apache.org>
>>>>>>> wrote:
>>>>>>>> Julian, are you looking at 741/743 or should I take a look?
>>>>>>>> 
>>>>>>>> On Tue, Jul 28, 2015 at 4:03 PM, Julian Hyde <jhyde@apache.org>
>>>>>>> wrote:
>>>>>>>> 
>>>>>>>>> I think you should include 811. It adds 3 new instances
of a rule
>>>>>>> but
>>>>>>>>> does not change the existing one.
>>>>>>>>> 
>>>>>>>>> I don't believe that Hive's test run has finished. Jesus,
can you
>>>>>>>>> report when you have some results?
>>>>>>>>> 
>>>>>>>>> Still to do are release-related changes: release notes,
741, 743.
>>>>>>> I
>>>>>>>>> can do the web site after the RC.
>>>>>>>>> 
>>>>>>>>> I was hoping to get Maryann's patch to 793 in, but I
still don't
>>>>>>> have
>>>>>>>>> a test case, so let's defer that one.
>>>>>>>>> 
>>>>>>>>> Julian
>>>>>>>>> 
>>>>>>>>> On Tue, Jul 28, 2015 at 3:23 PM, Jacques Nadeau
>>>>>>> <jacques@apache.org>
>>>>>>>>> wrote:
>>>>>>>>>> It seems like everyone is happy with the current
release.  The
>>>>>>> issue
>>>>>>>>>> identified by Hive looks like it was a Hive fix rather
than a
>>>>>>> Calcite
>>>>>>>>> one.
>>>>>>>>>> I noticed that Jesus committed one thing after my
proposed
>>>>>>> release.
>>>>>>> Do
>>>>>>>>>> people feel like that is absolutely required in this
release/the
>>>>>>> risk
>>>>>>>>>> involved?  I'm fine including it but am initially
inclined to
>>>>>>> leave it
>>>>>>>>> for
>>>>>>>>>> the next release if it isn't pressing.  The jira:
>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-811
>>>>>>>>>> 
>>>>>>>>>> Thoughts?
>>>>>>>>>> 
>>>>>>>>>> On Mon, Jul 27, 2015 at 12:32 PM, Julian Hyde <jhyde@apache.org>
>>>>>>> wrote:
>>>>>>>>>> 
>>>>>>>>>>> I¹ve tried the compile against Hive[1], fixed
a minor problem
>>>>>>> (related
>>>>>>>>> to
>>>>>>>>>>> SortFactory), and now Jesus is going to run the
Hive suite.
>>>>>>>>>>> 
>>>>>>>>>>> Jacques, If you¹re writing release notes you
might find my
>>>>>>> relNotes[2]
>>>>>>>>>>> script useful.
>>>>>>>>>>> 
>>>>>>>>>>> Julian
>>>>>>>>>>> 
>>>>>>>>>>> [1] https://issues.apache.org/jira/browse/HIVE-11383
>>>>>>>>>>> [2] 
>>>>>>> https://github.com/julianhyde/share/blob/master/tools/relNotes
>>>>>>>>>>> 
>>>>>>>>>>> On Jul 24, 2015, at 7:35 PM, Jacques Nadeau
>>>>>>> <jacques@apache.org>
>>>>>>> wrote:
>>>>>>>>>>> 
>>>>>>>>>>>> I've pushed a 1.4.0-SNAPSHOT to the Apache
Snapshot Repo.
>>>>>>> Framework
>>>>>>>>>>>> owners, please try out this branch and report
back whether
>>>>>>> you
>>>>>>> see
>>>>>>> any
>>>>>>>>>>>> showstopping regressions.  That way we can
work out any kinks
>>>>>>> before
>>>>>>>>> we
>>>>>>>>>>> put
>>>>>>>>>>>> this to an actual release vote.
>>>>>>>>>>>> 
>>>>>>>>>>>> You can to the current commit by adding the
following maven
>>>>>>> snapshot
>>>>>>>>>>>> repository to your pom.xml:
>>>>>>>>>>>> 
>>>>>>>>>>>> https://repository.apache.org/content/repositories/snapshots/
>>>>>>>>>>>> 
>>>>>>>>>>>> The version of the artifacts to reference
is 1.4.0-SNAPSHOT.
>>>>>>> The
>>>>>>>>>>> artifacts
>>>>>>>>>>>> are currently based on git commit
>>>>>>>>>>> 5cb95e644f38da1a13d6def96eeec935b650289c.
>>>>>>>>>>>> 
>>>>>>>>>>>> I'll target sending an actual release vote
EOD Tuesday
>>>>>>> unless we
>>>>>>> find
>>>>>>>>>>>> additional issues.
>>>>>>>>>>>> 
>>>>>>>>>>>> Thanks,
>>>>>>>>>>>> Jacques
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>> 
>>>>>>> 
>>>>> 
>>> 
>> 
>
>

Mime
View raw message