bval-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mben...@apache.org
Subject svn commit: r1629536 - /bval/branches/bval-11/bval-jsr/src/main/java/org/apache/bval/jsr/ApacheValidationProvider.java
Date Sun, 05 Oct 2014 20:24:31 GMT
Author: mbenson
Date: Sun Oct  5 20:24:31 2014
New Revision: 1629536

URL: http://svn.apache.org/r1629536
Log:
address a FIXME item in the code; seems to be valid

Modified:
    bval/branches/bval-11/bval-jsr/src/main/java/org/apache/bval/jsr/ApacheValidationProvider.java

Modified: bval/branches/bval-11/bval-jsr/src/main/java/org/apache/bval/jsr/ApacheValidationProvider.java
URL: http://svn.apache.org/viewvc/bval/branches/bval-11/bval-jsr/src/main/java/org/apache/bval/jsr/ApacheValidationProvider.java?rev=1629536&r1=1629535&r2=1629536&view=diff
==============================================================================
--- bval/branches/bval-11/bval-jsr/src/main/java/org/apache/bval/jsr/ApacheValidationProvider.java
(original)
+++ bval/branches/bval-11/bval-jsr/src/main/java/org/apache/bval/jsr/ApacheValidationProvider.java
Sun Oct  5 20:24:31 2014
@@ -88,21 +88,6 @@ public class ApacheValidationProvider im
             throw new ValidationException("error building ValidatorFactory", ex);
         }
 
-        // FIXME 2011-03-27 jw:
-        // Should not use privileged action, but to avoid breaking things
-        // doing it here like the former version of this class did.
-        //
-        // The privileged action should be applied by the ValidatorFactory
-        // itself, if required.
-        // No privileges should be required to access the constructor,
-        // because the classloader of ApacheValidationProvider will always
-        // be an ancestor of the loader of validatorFactoryClass.
-        return instantiateValidatorFactory(validatorFactoryClass, configuration);
-    }
-
-    @Privileged
-    private static ValidatorFactory instantiateValidatorFactory(
-        final Class<? extends ValidatorFactory> validatorFactoryClass, final ConfigurationState
configuration) {
         try {
             return validatorFactoryClass.getConstructor(ConfigurationState.class).newInstance(configuration);
         } catch (final Exception ex) {



Mime
View raw message