Mailing-List: contact users-help@buildr.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@buildr.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
From: Niklaus Giger <niklaus.giger@member.fsf.org>
To: users@buildr.apache.org
Subject: Re: Opened Ticket BUILDR-641: should allow java files without a class
 definition (e.g package-info.java)
Date: Fri, 4 May 2012 07:55:45 +0200
User-Agent: KMail/1.13.7 (Linux/3.2.0-2-amd64; KDE/4.6.5; x86_64; ; )
Cc: Alex Boisvert <alex.boisvert@gmail.com>
References: <201205032139.38413.niklaus.giger@member.fsf.org>
 <CAHuk3y6385wOXp2QF=oXy7eMGkYzzqX0S997JLiMWcf_QmNZ2Q@mail.gmail.com>
In-Reply-To: 
 <CAHuk3y6385wOXp2QF=oXy7eMGkYzzqX0S997JLiMWcf_QmNZ2Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201205040755.46349.niklaus.giger@member.fsf.org>

Hi Alex

Thanks a lot for your workaround! It is a nice workaround for the time being.

Best regards

Niklaus

> Hi Niklaus,
> 
> Yes, that's a bug -- we should exclude these types of files from
> dependencies.
> 
> Here's a quick hackish workaround for the time being,
> 
> # Monkey-patch Javac compiler to exclude package-info.java from
> dependencies module Buildr
>   module Compiler
>     class Javac
>       protected
>       def compile_map(sources, target)
>         map = super(sources, target)
>         map.reject { |k, v| k =~ /package-info.java$/ }
>       end
>     end
>   end
> end
> 
> alex
> 
> 
> On Thu, May 3, 2012 at 12:39 PM, Niklaus Giger
> <niklaus.giger@member.fsf.org
> 
> > wrote:
> > 
> > Hi
> > 
> > I stumbled in my project about various files, which where created just to
> > generate javadoc and had no valid class definition.
> > 
> > My colleague argued that this behaviour is okay as documented under
> > 
> > http://docs.oracle.com/javase/6/docs/technotes/tools/solaris/javadoc.html
> > #sourcefiles
> > 
> > Did anybody else stumble about this problem?
> > Or is there somewhere a simple way to exclude out package-info.java files
> > from
> > projecte.compile.sources?
> > 
> > Thanks in advance for your help.
> > 
> > Best regards
> > 
> > --
> > Niklaus Giger
-- 
Niklaus Giger
Wieshoschet 6
CH-8753 Mollis
+41  (0)55 612 20 54 P
+41  (0)77 473 02 59 Mobil