Return-Path: 
 <dev-return-996-apmail-buildr-dev-archive=buildr.apache.org@buildr.apache.org>
Delivered-To: apmail-buildr-dev-archive@www.apache.org
Received: (qmail 84707 invoked from network); 18 Jun 2009 19:29:46 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 18 Jun 2009 19:29:46 -0000
Received: (qmail 65021 invoked by uid 500); 18 Jun 2009 19:29:57 -0000
Delivered-To: apmail-buildr-dev-archive@buildr.apache.org
Received: (qmail 64979 invoked by uid 500); 18 Jun 2009 19:29:57 -0000
Mailing-List: contact dev-help@buildr.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@buildr.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@buildr.apache.org>
List-Post: <mailto:dev@buildr.apache.org>
List-Id: <dev.buildr.apache.org>
Reply-To: dev@buildr.apache.org
Delivered-To: mailing list dev@buildr.apache.org
Received: (qmail 64968 invoked by uid 99); 18 Jun 2009 19:29:57 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Jun 2009 19:29:57 +0000
X-ASF-Spam-Status: No, hits=2.2 required=10.0
	tests=HTML_MESSAGE,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of arkin@intalio.com designates
 209.85.221.178 as permitted sender)
Received: from [209.85.221.178] (HELO mail-qy0-f178.google.com)
 (209.85.221.178)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Jun 2009 19:29:49 +0000
Received: by qyk8 with SMTP id 8so1658236qyk.19
        for <dev@buildr.apache.org>; Thu, 18 Jun 2009 12:29:26 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.220.96.13 with SMTP id f13mr2056882vcn.118.1245353366276;
 Thu,
	18 Jun 2009 12:29:26 -0700 (PDT)
In-Reply-To: <3de5d7d20906170837u51617bey8e15508890a6558e@mail.gmail.com>
References: <5582dd3b0906161833y4058eec8t9407141e4e783516@mail.gmail.com>
	<C0F3C6FF-28CD-4AFC-80FB-BF773F4A8AB5@gmail.com>
 <5c99d0330906170828h779b06a1udd1b0015079336c5@mail.gmail.com>
	<3de5d7d20906170837u51617bey8e15508890a6558e@mail.gmail.com>
From: Assaf Arkin <arkin@intalio.com>
Date: Thu, 18 Jun 2009 12:29:06 -0700
Message-ID: <3de5d7d20906181229o7ec1827cw67cfac40cdc4e59d@mail.gmail.com>
Subject: Re: Failing Scala BDD specs
To: dev@buildr.apache.org
Content-Type: multipart/alternative; boundary=0016e6464766044af0046ca46dda
X-Virus-Checked: Checked by ClamAV on apache.org

--0016e6464766044af0046ca46dda
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

In lib/buildr/scala/tests.rb lines 112, 113:
ant.includes group_includes.join(" ") if group_includes
ant.excludes group_excludes.join(" ") if group_excludes

The arguments should be name/value pairs, a string argument doesn't do much
good. Commenting out these two lines doesn't break tests_spec.rb.

Assaf


On Wed, Jun 17, 2009 at 8:37 AM, Assaf Arkin <arkin@intalio.com> wrote:

> On Wed, Jun 17, 2009 at 8:28 AM, Daniel Spiewak <djspiewak@gmail.com>wrote:
>
>> Turns out that I just hadn't updated the specs to add the $ back into the
>> expected lists.  Specifications are defined as singleton objects, which
>> means that the test class which is running is actually '<specName>$'.  I
>> used to trim off that trailing $, but that isn't really an option with the
>> new spec runner.  Ideas welcome here.
>>
>> Incidentally, the new spec runner does provide some very important
>> benefits
>> -- like being able to detect and run *any* bona fide specification object,
>> not just the ones which lack companion classes.  Also, this spec runner
>> makes it possible in future to run specifications defined as classes
>> (rather
>> than objects), something which is supported by Specs but not Buildr.  So,
>> the solution isn't to just drop the new runner; I just have to figure out
>> a
>> way to make this work without exposing all those ugly $ characters to the
>> end-user.
>>
>> In the meantime, I've fixed the specs and committed the results.
>>
>
> Awsome. I'm working on getting all the specs to pass with Ruby 1.9, one set
> at a time, so I need specs to first pass with 1.8.
>
> Assaf
>
>
>>
>> Daniel
>>
>> On Tue, Jun 16, 2009 at 9:53 PM, Daniel Spiewak <djspiewak@gmail.com>
>> wrote:
>>
>> > Those tests were passing for me yesterday, before the Rspec upgrade.
>>  Well,
>> > *some* of them were passing.  Most were throwing errors about a helper
>> > method.  I'll take a look at it tomorrow to see if I can reproduce the
>> > failures.
>> >
>> > Daniel
>> >
>> >
>> > On Jun 16, 2009, at 8:33 PM, Alex Boisvert <boisvert@intalio.com>
>> wrote:
>> >
>> >  Hi Daniel,
>> >>
>> >> Assaf and I noticed some failures in spec/scala/bdd_spec.rb today.  Do
>> the
>> >> following specs fail for you?
>> >>
>> >> 1)
>> >> 'Buildr::Scala::Specs should include public classes extending
>> >> org.specs.Specification' FAILED
>> >> expected ["com.example.MySpecs$"] to include "com.example.MySpecs"
>> >> ./spec/scala/bdd_spec.rb:68:
>> >>
>> >> 2)
>> >> 'Buildr::Scala::Specs should include public classes extending
>> >> org.specs.Specification even with companion classes' FAILED
>> >> expected ["com.example.MySpecs$"] to include "com.example.MySpecs"
>> >> ./spec/scala/bdd_spec.rb:85:
>> >>
>> >> 3)
>> >> 'Buildr::Scala::Specs should report failed test names' FAILED
>> >> expected ["FailingSpecs$"] to include "FailingSpecs"
>> >> ./spec/scala/bdd_spec.rb:128:
>> >>
>> >> 4)
>> >> 'Buildr::Scala::Specs should compile and run specifications with
>> "Specs"
>> >> suffix' FAILED
>> >> expected ["HelloWorldSpecs$"] to include "HelloWorldSpecs"
>> >> ./spec/scala/bdd_spec.rb:146:
>> >>
>> >> 5)
>> >> 'Buildr::Scala::Specs should fail if specifications fail' FAILED
>> >> expected ["StringSpecs$"] to include "StringSpecs"
>> >> ./spec/scala/bdd_spec.rb:165:
>> >>
>> >> Finished in 14.103377 seconds
>> >>
>> >> 11 examples, 5 failures
>> >>
>> >> alex
>> >>
>> >
>>
>
>

--0016e6464766044af0046ca46dda--