buildr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BUILDR-454) Definition-level parent-child references-by-name fail in 1.4.0 but not in 1.3.5
Date Sun, 14 Aug 2016 05:45:20 GMT

    [ https://issues.apache.org/jira/browse/BUILDR-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420224#comment-15420224
] 

ASF GitHub Bot commented on BUILDR-454:
---------------------------------------

GitHub user atoulme opened a pull request:

    https://github.com/apache/buildr/pull/22

    BUILDR-454: Definition-level parent-child references-by-name fail in …

    …1.4.0 but not in 1.3.5

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/atoulme/buildr BUILDR-454

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/buildr/pull/22.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22
    
----
commit a850d8c98bf32a5f8fe14e274155efdf822dcb45
Author: Antoine Toulme <antoine@lunar-ocean.com>
Date:   2016-08-14T05:44:02Z

    BUILDR-454: Definition-level parent-child references-by-name fail in 1.4.0 but not in
1.3.5

----


> Definition-level parent-child references-by-name fail in 1.4.0 but not in 1.3.5
> -------------------------------------------------------------------------------
>
>                 Key: BUILDR-454
>                 URL: https://issues.apache.org/jira/browse/BUILDR-454
>             Project: Buildr
>          Issue Type: Bug
>          Components: Core features
>    Affects Versions: 1.4
>         Environment: OS X 10.6.3, JRuby 1.4.0 (but it shouldn't matter)
>            Reporter: Rhett Sutphin
>            Assignee: Antoine Toulme
>             Fix For: 1.5
>
>         Attachments: circular_project_deps.patch
>
>
> A buildfile like this one:
> define "root" do
>   define "child" do
>     puts project('root')._('foo.resource')
>   end
> end
> will work fine on buildr 1.3.5.  However, it fails with a circular dependency error on
1.4.0 RC4:
> RuntimeError : Circular dependency detected: TOP => root => root:child => root
> /private/tmp/buildr-problem/buildfile:3
> I don't think this need block the release because the following workaround succeeds in
both:
> define "root" do
>   define "child" do
>     puts project.parent._('foo.resource')
>   end
> end



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message