Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 860E8200AE1 for ; Sun, 22 May 2016 12:50:45 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 84EAE160A06; Sun, 22 May 2016 10:50:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 68768160A2E for ; Sun, 22 May 2016 12:50:44 +0200 (CEST) Received: (qmail 2656 invoked by uid 500); 22 May 2016 10:50:43 -0000 Mailing-List: contact commits-help@buildr.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@buildr.apache.org Delivered-To: mailing list commits@buildr.apache.org Received: (qmail 2558 invoked by uid 99); 22 May 2016 10:50:43 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 May 2016 10:50:43 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 3C296DFF12; Sun, 22 May 2016 10:50:43 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: donaldp@apache.org To: commits@buildr.apache.org Date: Sun, 22 May 2016 10:50:44 -0000 Message-Id: <6a3711d2474c4d8aaf186ff22b49cf41@git.apache.org> In-Reply-To: <3326085767eb4ac6aef4da17915572be@git.apache.org> References: <3326085767eb4ac6aef4da17915572be@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [02/11] buildr git commit: Prefer single quotes archived-at: Sun, 22 May 2016 10:50:45 -0000 Prefer single quotes Project: http://git-wip-us.apache.org/repos/asf/buildr/repo Commit: http://git-wip-us.apache.org/repos/asf/buildr/commit/7cbe77cd Tree: http://git-wip-us.apache.org/repos/asf/buildr/tree/7cbe77cd Diff: http://git-wip-us.apache.org/repos/asf/buildr/diff/7cbe77cd Branch: refs/heads/master Commit: 7cbe77cde78bd7b7e1a08f4cba9e66660f24be63 Parents: 8655033 Author: Peter Donald Authored: Sun May 22 20:07:00 2016 +1000 Committer: Peter Donald Committed: Sun May 22 20:07:00 2016 +1000 ---------------------------------------------------------------------- spec/addon/custom_pom_spec.rb | 60 +++++++++++++++++++------------------- 1 file changed, 30 insertions(+), 30 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/buildr/blob/7cbe77cd/spec/addon/custom_pom_spec.rb ---------------------------------------------------------------------- diff --git a/spec/addon/custom_pom_spec.rb b/spec/addon/custom_pom_spec.rb index c49b766..15843e7 100644 --- a/spec/addon/custom_pom_spec.rb +++ b/spec/addon/custom_pom_spec.rb @@ -65,7 +65,7 @@ describe Buildr::CustomPom do verify_dependency_optional(pom_xml, artifact_id, optional) end - describe "with explicitly specified pom details" do + describe 'with explicitly specified pom details' do before do %w(id-provided id-optional id-runtime id-test).each do |artifact_id| artifact("group:#{artifact_id}:jar:1.0") do |t| @@ -75,7 +75,7 @@ describe Buildr::CustomPom do end end end - write 'src/main/java/Example.java', "public class Example {}" + write 'src/main/java/Example.java', 'public class Example {}' @foo = define 'foo' do project.group = 'org.myproject' @@ -100,50 +100,50 @@ describe Buildr::CustomPom do end task('package').invoke @pom_xml = project_pom_xml(@foo) - #$stderr.puts @pom_xml.to_s + $stderr.puts @pom_xml.to_s end - it "has correct static metadata" do - @pom_xml.should match_xpath("/project/modelVersion", '4.0.0') - @pom_xml.should match_xpath("/project/parent/groupId", 'org.sonatype.oss') - @pom_xml.should match_xpath("/project/parent/artifactId", 'oss-parent') - @pom_xml.should match_xpath("/project/parent/version", '7') + it 'has correct static metadata' do + @pom_xml.should match_xpath('/project/modelVersion', '4.0.0') + @pom_xml.should match_xpath('/project/parent/groupId', 'org.sonatype.oss') + @pom_xml.should match_xpath('/project/parent/artifactId', 'oss-parent') + @pom_xml.should match_xpath('/project/parent/version', '7') end - it "has correct project level metadata" do - @pom_xml.should match_xpath("/project/groupId", 'org.myproject') - @pom_xml.should match_xpath("/project/artifactId", 'foo') - @pom_xml.should match_xpath("/project/version", '1.0') - @pom_xml.should match_xpath("/project/packaging", 'jar') - @pom_xml.should match_xpath("/project/name", 'foo') - @pom_xml.should match_xpath("/project/description", 'foo') - @pom_xml.should match_xpath("/project/url", 'https://github.com/jbloggs/myproject') + it 'has correct project level metadata' do + @pom_xml.should match_xpath('/project/groupId', 'org.myproject') + @pom_xml.should match_xpath('/project/artifactId', 'foo') + @pom_xml.should match_xpath('/project/version', '1.0') + @pom_xml.should match_xpath('/project/packaging', 'jar') + @pom_xml.should match_xpath('/project/name', 'foo') + @pom_xml.should match_xpath('/project/description', 'foo') + @pom_xml.should match_xpath('/project/url', 'https://github.com/jbloggs/myproject') end - it "has correct scm details" do - @pom_xml.should match_xpath("/project/scm/connection", 'scm:git:git@github.com:jbloggs/myproject') - @pom_xml.should match_xpath("/project/scm/developerConnection", 'scm:git:git@github.com:jbloggs/myproject') - @pom_xml.should match_xpath("/project/scm/url", 'git@github.com:jbloggs/myproject') + it 'has correct scm details' do + @pom_xml.should match_xpath('/project/scm/connection', 'scm:git:git@github.com:jbloggs/myproject') + @pom_xml.should match_xpath('/project/scm/developerConnection', 'scm:git:git@github.com:jbloggs/myproject') + @pom_xml.should match_xpath('/project/scm/url', 'git@github.com:jbloggs/myproject') end - it "has correct issueManagement details" do - @pom_xml.should match_xpath("/project/issueManagement/url", 'https://github.com/jbloggs/myproject/issues') - @pom_xml.should match_xpath("/project/issueManagement/system", 'GitHub Issues') + it 'has correct issueManagement details' do + @pom_xml.should match_xpath('/project/issueManagement/url', 'https://github.com/jbloggs/myproject/issues') + @pom_xml.should match_xpath('/project/issueManagement/system', 'GitHub Issues') end - it "has correct developers details" do - @pom_xml.should match_xpath("/project/developers/developer/id", 'jbloggs') - @pom_xml.should match_xpath("/project/developers/developer/name", 'Joe Bloggs') - @pom_xml.should match_xpath("/project/developers/developer/email", 'jbloggs@example.com') - @pom_xml.should match_xpath("/project/developers/developer/roles/role", 'Project Lead') + it 'has correct developers details' do + @pom_xml.should match_xpath('/project/developers/developer/id', 'jbloggs') + @pom_xml.should match_xpath('/project/developers/developer/name', 'Joe Bloggs') + @pom_xml.should match_xpath('/project/developers/developer/email', 'jbloggs@example.com') + @pom_xml.should match_xpath('/project/developers/developer/roles/role', 'Project Lead') end - it "has correct license details" do + it 'has correct license details' do verify_license(@pom_xml, 'The Apache Software License, Version 2.0', 'http://www.apache.org/licenses/LICENSE-2.0.txt') verify_license(@pom_xml, 'GNU General Public License (GPL) version 3.0', 'http://www.gnu.org/licenses/gpl-3.0.html') end - it "has correct dependency details" do + it 'has correct dependency details' do verify_dependency(@pom_xml, 'id-runtime', 'group', '1.0', nil, nil) verify_dependency(@pom_xml, 'id-optional', 'group', '1.0', nil, 'true') verify_dependency(@pom_xml, 'id-provided', 'group', '1.0', 'provided', nil)