Return-Path: X-Original-To: apmail-buildr-commits-archive@www.apache.org Delivered-To: apmail-buildr-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4BDC718F6E for ; Fri, 27 Nov 2015 09:10:36 +0000 (UTC) Received: (qmail 61257 invoked by uid 500); 27 Nov 2015 09:10:36 -0000 Delivered-To: apmail-buildr-commits-archive@buildr.apache.org Received: (qmail 61192 invoked by uid 500); 27 Nov 2015 09:10:35 -0000 Mailing-List: contact commits-help@buildr.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@buildr.apache.org Delivered-To: mailing list commits@buildr.apache.org Received: (qmail 61073 invoked by uid 99); 27 Nov 2015 09:10:35 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Nov 2015 09:10:35 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id BFE81DFD87; Fri, 27 Nov 2015 09:10:35 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: donaldp@apache.org To: commits@buildr.apache.org Date: Fri, 27 Nov 2015 09:10:38 -0000 Message-Id: <996c5069b35244c9a7369ffa78f43eb2@git.apache.org> In-Reply-To: <4896cf4b2f774bb493a61797e4c5504b@git.apache.org> References: <4896cf4b2f774bb493a61797e4c5504b@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [4/5] buildr git commit: Avoid messing around with outputfile and assume checkstyle command line application behaves sensibly Avoid messing around with outputfile and assume checkstyle command line application behaves sensibly Project: http://git-wip-us.apache.org/repos/asf/buildr/repo Commit: http://git-wip-us.apache.org/repos/asf/buildr/commit/8b77fa2d Tree: http://git-wip-us.apache.org/repos/asf/buildr/tree/8b77fa2d Diff: http://git-wip-us.apache.org/repos/asf/buildr/diff/8b77fa2d Branch: refs/heads/master Commit: 8b77fa2d9aa35c75eeddd4f984124be9e2b40eb5 Parents: ccf2521 Author: Peter Donald Authored: Fri Nov 27 18:07:11 2015 +1100 Committer: Peter Donald Committed: Fri Nov 27 18:07:11 2015 +1100 ---------------------------------------------------------------------- addon/buildr/checkstyle.rb | 2 -- 1 file changed, 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/buildr/blob/8b77fa2d/addon/buildr/checkstyle.rb ---------------------------------------------------------------------- diff --git a/addon/buildr/checkstyle.rb b/addon/buildr/checkstyle.rb index 011b0a7..774ba9d 100644 --- a/addon/buildr/checkstyle.rb +++ b/addon/buildr/checkstyle.rb @@ -53,10 +53,8 @@ module Buildr args += source_paths.select { |p| File.exist?(p) } begin - touch output_file Java::Commands.java 'com.puppycrawl.tools.checkstyle.Main', *(args + [{:classpath => cp, :properties => options[:properties], :java_args => options[:java_args]}]) rescue Exception => e - rm_f output_file raise e if options[:fail_on_error] end end