Mailing-List: contact commits-help@buildr.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@buildr.apache.org
Date: Mon, 15 Apr 2013 15:50:15 +0000 (UTC)
From: "Dieter Vrancken (JIRA)" <jira@apache.org>
To: buildr-commits@incubator.apache.org
Message-ID: <JIRA.12640263.1364897104938.167851.1366041015771@arcas>
In-Reply-To: <JIRA.12640263.1364897104938@arcas>
References: <JIRA.12640263.1364897104938@arcas>
Subject: [jira] [Commented] (BUILDR-664) Checkstyle addon extra_dependencies
 should not include compile/test libs by default
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/BUILDR-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631808#comment-13631808 ] 

Dieter Vrancken commented on BUILDR-664:
----------------------------------------

Hi Peter, reading the documentation for their ant task, it looks like the compile dependencies of the checked code are not actually needed by Checkstyle. Also, all our build scripts over the past years ran Checkstyle without giving it these dependencies. Checkstyle uses the source files only, no?
                
> Checkstyle addon extra_dependencies should not include compile/test libs by default
> -----------------------------------------------------------------------------------
>
>                 Key: BUILDR-664
>                 URL: https://issues.apache.org/jira/browse/BUILDR-664
>             Project: Buildr
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: 1.4.10
>            Reporter: Dieter Vrancken
>            Priority: Minor
>
> The experimental Buildr::Checkstyle addon contains the following method:
>     def extra_dependencies
>         @extra_dependencies ||= [self.project.compile.dependencies, self.project.test.compile.dependencies].flatten
>     end
> Also, checkstyle itself depends on an ancient version of google-collections library.
> We were bitten by this in that our code depends on a newer version of the guava library (successor to google-collections) in which a method used by checkstyle has been removed.
> Since checkstyle does not require access to the runtime dependencies of the code that is checked, I propose to make the default value of @extra_dependencies empty: [].

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira