buildr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dona...@apache.org
Subject svn commit: r1469192 - /buildr/trunk/spec/java/bdd_spec.rb
Date Thu, 18 Apr 2013 07:10:04 GMT
Author: donaldp
Date: Thu Apr 18 07:10:04 2013
New Revision: 1469192

URL: http://svn.apache.org/r1469192
Log:
Disable some tests that were;
* disabled in jenkins
* only executed under jruby

They rely on a locally configured jruby that is never going to be true on our CI infrastructure
and is unlikely to be true when running through bundler etc

Modified:
    buildr/trunk/spec/java/bdd_spec.rb

Modified: buildr/trunk/spec/java/bdd_spec.rb
URL: http://svn.apache.org/viewvc/buildr/trunk/spec/java/bdd_spec.rb?rev=1469192&r1=1469191&r2=1469192&view=diff
==============================================================================
--- buildr/trunk/spec/java/bdd_spec.rb (original)
+++ buildr/trunk/spec/java/bdd_spec.rb Thu Apr 18 07:10:04 2013
@@ -27,34 +27,30 @@ describe Buildr::RSpec do
     project('foo').test.framework.should eql(:rspec)
   end
 
-  it 'should read passed specs from result yaml' do
-    # This test fails on the CI machine if the spec is run as part of a suite but not if
run individually
-    # This seems to indicate that there is interaction with some other test but until that
other test is
-    # identified the test has been marked as pending on the ci box
-    pending "Unable to determine why it fails on the CI machine so disabling" if ENV['JOB_NAME']
-    write('src/spec/ruby/success_spec.rb', 'describe("success") { it("is true") { nil.should
be_nil } }')
-
-    project('foo').test.invoke
-    project('foo').test.passed_tests.should eql([File.expand_path('src/spec/ruby/success_spec.rb')])
-  end
-
-  it 'should read result yaml to obtain the list of failed specs' do
-    # This test fails on the CI machine if the spec is run as part of a suite but not if
run individually
-    # This seems to indicate that there is interaction with some other test but until that
other test is
-    # identified the test has been marked as pending on the ci box
-    pending "Unable to determine why it fails on the CI machine so disabling" if ENV['JOB_NAME']
-    success = File.expand_path('src/spec/ruby/success_spec.rb')
-    write(success, 'describe("success") { it("is true") { nil.should be_nil } }')
-    failure = File.expand_path('src/spec/ruby/failure_spec.rb')
-    write(failure, 'describe("failure") { it("is false") { true.should == false } }')
-    error = File.expand_path('src/spec/ruby/error_spec.rb')
-    write(error, 'describe("error") { it("raises") { lambda; } }')
-
-    lambda { project('foo').test.invoke }.should raise_error(/Tests failed/)
-    project('foo').test.tests.should include(success, failure, error)
-    project('foo').test.failed_tests.sort.should eql([failure, error].sort)
-    project('foo').test.passed_tests.should eql([success])
-
+  # These tests will fail because they expect that a version of rspec will be present in
the local gem
+  # repository for the jruby that comes out of the maven repository but this is not the case.
Disabling
+  # These across the board until someone wants to invest the time in refactoring them to
work
+  if false
+    it 'should read passed specs from result yaml' do
+      write('src/spec/ruby/success_spec.rb', 'describe("success") { it("is true") { nil.should
be_nil } }')
+
+      project('foo').test.invoke
+      project('foo').test.passed_tests.should eql([File.expand_path('src/spec/ruby/success_spec.rb')])
+    end
+
+    it 'should read result yaml to obtain the list of failed specs' do
+      success = File.expand_path('src/spec/ruby/success_spec.rb')
+      write(success, 'describe("success") { it("is true") { nil.should be_nil } }')
+      failure = File.expand_path('src/spec/ruby/failure_spec.rb')
+      write(failure, 'describe("failure") { it("is false") { true.should == false } }')
+      error = File.expand_path('src/spec/ruby/error_spec.rb')
+      write(error, 'describe("error") { it("raises") { lambda; } }')
+
+      lambda { project('foo').test.invoke }.should raise_error(/Tests failed/)
+      project('foo').test.tests.should include(success, failure, error)
+      project('foo').test.failed_tests.sort.should eql([failure, error].sort)
+      project('foo').test.passed_tests.should eql([success])
+    end
   end
 
 end if RUBY_PLATFORM =~ /java/ || ENV['JRUBY_HOME'] # RSpec



Mime
View raw message