Return-Path: X-Original-To: apmail-buildr-commits-archive@www.apache.org Delivered-To: apmail-buildr-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D287AE444 for ; Mon, 7 Jan 2013 21:17:43 +0000 (UTC) Received: (qmail 4600 invoked by uid 500); 7 Jan 2013 21:17:43 -0000 Delivered-To: apmail-buildr-commits-archive@buildr.apache.org Received: (qmail 4576 invoked by uid 500); 7 Jan 2013 21:17:43 -0000 Mailing-List: contact commits-help@buildr.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@buildr.apache.org Delivered-To: mailing list commits@buildr.apache.org Received: (qmail 4566 invoked by uid 99); 7 Jan 2013 21:17:43 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Jan 2013 21:17:43 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Jan 2013 21:17:41 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 1FD1423888CD; Mon, 7 Jan 2013 21:17:21 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1430017 - in /buildr/trunk: CHANGELOG addon/buildr/findbugs.rb Date: Mon, 07 Jan 2013 21:17:21 -0000 To: commits@buildr.apache.org From: donaldp@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20130107211721.1FD1423888CD@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: donaldp Date: Mon Jan 7 21:17:20 2013 New Revision: 1430017 URL: http://svn.apache.org/viewvc?rev=1430017&view=rev Log: Findbugs addon correctly handles String dependencies (vs task dependencies) Modified: buildr/trunk/CHANGELOG buildr/trunk/addon/buildr/findbugs.rb Modified: buildr/trunk/CHANGELOG URL: http://svn.apache.org/viewvc/buildr/trunk/CHANGELOG?rev=1430017&r1=1430016&r2=1430017&view=diff ============================================================================== --- buildr/trunk/CHANGELOG (original) +++ buildr/trunk/CHANGELOG Mon Jan 7 21:17:20 2013 @@ -1,4 +1,6 @@ 1.4.10 (Pending) +* Fixed: Findbugs addon correctly handles String dependencies + (vs task dependencies) * Fixed: Checkstyle addon correctly handles String dependencies (vs task dependencies) * Added: Created an addon 'buildr/wsgen' for generating wsdls from java Modified: buildr/trunk/addon/buildr/findbugs.rb URL: http://svn.apache.org/viewvc/buildr/trunk/addon/buildr/findbugs.rb?rev=1430017&r1=1430016&r2=1430017&view=diff ============================================================================== --- buildr/trunk/addon/buildr/findbugs.rb (original) +++ buildr/trunk/addon/buildr/findbugs.rb Mon Jan 7 21:17:20 2013 @@ -46,7 +46,7 @@ module Buildr def findbugs(output_file, source_paths, analyze_paths, options = { }) dependencies = (options[:dependencies] || []) + self.dependencies - cp = Buildr.artifacts(dependencies).each(&:invoke).map(&:to_s).join(File::PATH_SEPARATOR) + cp = Buildr.artifacts(dependencies).each { |a| a.invoke() if a.respond_to?(:invoke) }.map(&:to_s).join(File::PATH_SEPARATOR) args = { :output => "xml:withMessages", @@ -79,7 +79,7 @@ module Buildr end if options[:extra_dependencies] ant.auxClasspath do |aux| - Buildr.artifacts(options[:extra_dependencies]).each(&:invoke).each do |dep| + Buildr.artifacts(options[:extra_dependencies]).each { |a| a.invoke() if a.respond_to?(:invoke) }.each do |dep| aux.pathelement :location => dep.to_s end end