buildr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Donald (JIRA)" <>
Subject [jira] [Updated] (BUILDR-563) protobuf addon including source directories to protoc breaks build
Date Sat, 06 Oct 2012 23:49:06 GMT


Peter Donald updated BUILDR-563:

    Fix Version/s: 1.5
> protobuf addon including source directories to protoc breaks build
> ------------------------------------------------------------------
>                 Key: BUILDR-563
>                 URL:
>             Project: Buildr
>          Issue Type: Bug
>            Reporter: Robin Palotai
>            Priority: Trivial
>             Fix For: 1.5
> In "addon/buildr/protobuf.rb", the following line:
> (paths_from_sources(*args) + options[:include]).each { |i| command_line << "-I#{i}"
> Incorrectly puts "/a/b" on the include path for any input file "/a/b/xyz.proto". This
is bad, the user should support the _root_ include path(s) if they wish to, and not any paths
below it. The current scheme breaks compilation of proto files organised under an "a.b" package
> Excerpts from the message
> 'when you pass "../P/a.proto" on the command line, protoc concludes that because "../P"
is in the import path, this file's canonical name is "a.proto" [...] In general, you should
never pass overlapping -I flags to protoc.'
> Fix:
> Delete including the source directories, change the line to
> (options[:include]).each { |i| command_line << "-I#{i}" }
> and include the instruction to use the include path to the documentation.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message