buildr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Donald (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (BUILDR-325) Overriding package spec with classifer doesn't work
Date Wed, 22 Jun 2011 10:11:31 GMT

     [ https://issues.apache.org/jira/browse/BUILDR-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Peter Donald closed BUILDR-325.
-------------------------------


> Overriding package spec with classifer doesn't work
> ---------------------------------------------------
>
>                 Key: BUILDR-325
>                 URL: https://issues.apache.org/jira/browse/BUILDR-325
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Packaging
>    Affects Versions: 1.3.4
>            Reporter: Antoine Toulme
>             Fix For: 1.3.5
>
>         Attachments: buildrpatch, spec_BUILDR-325
>
>
> The current code in package.rb does this:
> package = (no_options && packages.detect { |pkg| pkg.type == spec[:type] ||
>           packages.find { |pkg| pkg.name == file_name }                             ||
>           packager.call(file_name)
> ie, if you define two packages that use the :zip type, only the first one will be taken
into account.
> I happen to work on Eclipse features, in which both the source and original features
work with the same type, but have different classifiers.
> So I'd like the code to do this instead:
> package = (no_options && packages.detect { |pkg| pkg.type == spec[:type] &&

>                   (spec[:classifier].nil? || pkg.classifier == spec[:classifier])}) ||
>           packages.find { |pkg| pkg.name == file_name }                             ||
>           packager.call(file_name)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message