buildr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (BUILDR-225) ArchiveTask#merge, not according to doc
Date Thu, 08 Jul 2010 03:13:52 GMT

    [ https://issues.apache.org/jira/browse/BUILDR-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886216#action_12886216
] 

Hudson commented on BUILDR-225:
-------------------------------

Integrated in Buildr-ci-build #53 (See [http://hudson.zones.apache.org/hudson/job/Buildr-ci-build/53/])
    fix for BUILDR-225 ArchiveTask#merge, not according to doc


> ArchiveTask#merge, not according to doc
> ---------------------------------------
>
>                 Key: BUILDR-225
>                 URL: https://issues.apache.org/jira/browse/BUILDR-225
>             Project: Buildr
>          Issue Type: Bug
>          Components: Packaging
>    Affects Versions: 1.3.2
>            Reporter: Ittay Dror
>             Fix For: 1.4.2
>
>
> The doc says
> # Returns an object that supports two methods: include and exclude. You can use these
methods to merge
> # only specific files. For example:
> #   zip(..).merge('src.zip').include('module1/*')
> but the implementation is:
>      source.entries.reject { |entry| entry.directory? }.each do |entry|
>             if @includes.any? { |pattern| File.fnmatch(pattern, entry.name, File::FNM_PATHNAME)
} &&
>                !@excludes.any? { |pattern| File.fnmatch(pattern, entry.name, File::FNM_PATHNAME)
}
> so it doesn't check directories, only files. so if the zip has module1/src/Foo.java,
the pattern 'module1/*' will not match and the file will not be included

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message