buildr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Antoine Toulme (JIRA)" <j...@apache.org>
Subject [jira] Created: (BUILDR-325) Let packages be defined with the same type but a different classifier
Date Wed, 30 Sep 2009 23:07:24 GMT
Let packages be defined with the same type but a different classifier
---------------------------------------------------------------------

                 Key: BUILDR-325
                 URL: https://issues.apache.org/jira/browse/BUILDR-325
             Project: Buildr
          Issue Type: Improvement
          Components: Packaging
    Affects Versions: 1.3.4
            Reporter: Antoine Toulme


The current code in package.rb does this:

package = (no_options && packages.detect { |pkg| pkg.type == spec[:type] ||
          packages.find { |pkg| pkg.name == file_name }                             ||
          packager.call(file_name)

ie, if you define two packages that use the :zip type, only the first one will be taken into
account.

I happen to work on Eclipse features, in which both the source and original features work
with the same type, but have different classifiers.

So I'd like the code to do this instead:

package = (no_options && packages.detect { |pkg| pkg.type == spec[:type] &&

                  (spec[:classifier].nil? || pkg.classifier == spec[:classifier])}) ||
          packages.find { |pkg| pkg.name == file_name }                             ||
          packager.call(file_name)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message