Return-Path: Delivered-To: apmail-incubator-buildr-commits-archive@locus.apache.org Received: (qmail 92323 invoked from network); 4 Aug 2008 22:13:35 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 4 Aug 2008 22:13:35 -0000 Received: (qmail 22426 invoked by uid 500); 4 Aug 2008 22:13:34 -0000 Delivered-To: apmail-incubator-buildr-commits-archive@incubator.apache.org Received: (qmail 22406 invoked by uid 500); 4 Aug 2008 22:13:34 -0000 Mailing-List: contact buildr-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: buildr-dev@incubator.apache.org Delivered-To: mailing list buildr-commits@incubator.apache.org Received: (qmail 22394 invoked by uid 99); 4 Aug 2008 22:13:34 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Aug 2008 15:13:34 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Aug 2008 22:12:47 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 73192234C185 for ; Mon, 4 Aug 2008 15:12:44 -0700 (PDT) Message-ID: <1654876711.1217887964457.JavaMail.jira@brutus> Date: Mon, 4 Aug 2008 15:12:44 -0700 (PDT) From: "Lacton (JIRA)" To: buildr-commits@incubator.apache.org Subject: [jira] Commented: (BUILDR-116) TestTask should include the main compile target in its dependencies, even when using non standard directories In-Reply-To: <1649890201.1217513193968.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/BUILDR-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619723#action_12619723 ] Lacton commented on BUILDR-116: ------------------------------- Thank you for the commit, Assaf. I think you applied BUILDR-116.spec.patch2 but forgot BUILDR-116.spec.patch in the process. > TestTask should include the main compile target in its dependencies, even when using non standard directories > ------------------------------------------------------------------------------------------------------------- > > Key: BUILDR-116 > URL: https://issues.apache.org/jira/browse/BUILDR-116 > Project: Buildr > Issue Type: Improvement > Components: Test frameworks > Environment: Trunk revision 680924 > Reporter: Lacton > Priority: Minor > Fix For: 1.3.3 > > Attachments: BUILDR-116.lib.patch, BUILDR-116.spec.patch, BUILDR-116.spec.patch2 > > > TestTask should include the main compile target in its dependencies, even when using non standard directories (e.g., 'src/java' instead of 'src/main/java'). > For instance, I have a project with java sources in 'src/java' and its junit tests in 'src/test'. The buildfile is roughly like this: >


> define 'my-project' do
>   compile _('src/java')
>   test.compile _('src/test')
> end
>

> 'buildr clean test' fails on test compilation because the main compile target (i.e., 'target/classes') is not in the TestTask's dependencies. The problem is that > 1. the main CompileTask tries to set its target directory during the 'before_define' phase, which is too early because it is before the "compile _('src/java')" line. > 2. the TestTask does not add the main compile target during the 'after_define' phase, because the main CompileTask still has no target at that time. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.