Return-Path: Delivered-To: apmail-incubator-buildr-commits-archive@locus.apache.org Received: (qmail 52941 invoked from network); 9 Jul 2008 06:10:52 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 9 Jul 2008 06:10:52 -0000 Received: (qmail 28462 invoked by uid 500); 9 Jul 2008 06:10:53 -0000 Delivered-To: apmail-incubator-buildr-commits-archive@incubator.apache.org Received: (qmail 28456 invoked by uid 500); 9 Jul 2008 06:10:53 -0000 Mailing-List: contact buildr-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: buildr-dev@incubator.apache.org Delivered-To: mailing list buildr-commits@incubator.apache.org Received: (qmail 28446 invoked by uid 99); 9 Jul 2008 06:10:53 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Jul 2008 23:10:53 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Jul 2008 06:10:09 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id EBFE3234C159 for ; Tue, 8 Jul 2008 23:10:31 -0700 (PDT) Message-ID: <947074108.1215583831952.JavaMail.jira@brutus> Date: Tue, 8 Jul 2008 23:10:31 -0700 (PDT) From: "Lacton (JIRA)" To: buildr-commits@incubator.apache.org Subject: [jira] Commented: (BUILDR-99) Tests should be run according to dependency order In-Reply-To: <1943349947.1215466832897.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/BUILDR-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611908#action_12611908 ] Lacton commented on BUILDR-99: ------------------------------ Thinking more about this issue, it occurred to me that the test order should respect test dependencies and not just compile dependencies. E.g., define "test_order2" do define "moduleA" do test.with project('moduleB') # moduleA has no compile dependencies, but it uses moduleB.jar at runtime for testing purpose. package :jar end define "moduleB" do package :jar end end I guess it means all test tasks of the projects figuring in the test dependencies of a given module should be run before running the test task of this module (e.g., 'moduleA:test'=>'moduleB:test'). That would mirror the behavior for compiling (i.e., all compile tasks of the projects figuring in the compile dependencies of a given module are run before running the compile task of this module). > Tests should be run according to dependency order > ------------------------------------------------- > > Key: BUILDR-99 > URL: https://issues.apache.org/jira/browse/BUILDR-99 > Project: Buildr > Issue Type: Improvement > Components: Test frameworks > Affects Versions: 1.3.1, 1.3.2 > Reporter: Lacton > Priority: Minor > Fix For: 1.3.3 > > > Let's have two modules, moduleA and moduleB. > Let's say moduleA depends on moduleB. > buildr compiles moduleB before compiling moduleA. This is the expected behavior. > Then buildr runs tests from moduleA before running tests from moduleB. This behavior can be misleading. A defect in moduleB could make a test in moduleA fail. The test process will stop at moduleA and will not show the failing test in moduleB. > Although the information that a test in moduleB is failing can be obtained by calling buildr with the 'test=all' option, it requires more intellectual effort to analyze the situation. > I propose buildr runs tests according to the test dependency tree. > define "test_order" do > define "moduleA" do > compile.with project('moduleB') > package :jar > end > define "moduleB" do > package :jar > end > end -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.