Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AFF63200D2F for ; Wed, 1 Nov 2017 18:47:16 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id AE797160BEA; Wed, 1 Nov 2017 17:47:16 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F1DD11609EC for ; Wed, 1 Nov 2017 18:47:15 +0100 (CET) Received: (qmail 7460 invoked by uid 500); 1 Nov 2017 17:47:15 -0000 Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.apache.org Delivered-To: mailing list dev@brooklyn.apache.org Received: (qmail 7448 invoked by uid 99); 1 Nov 2017 17:47:14 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Nov 2017 17:47:14 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id BE6A3DFB6F; Wed, 1 Nov 2017 17:47:14 +0000 (UTC) From: ahgittin To: dev@brooklyn.apache.org Reply-To: dev@brooklyn.apache.org Message-ID: Subject: [GitHub] brooklyn-server pull request #873: Upgrade types and bundles as per bundle m... Content-Type: text/plain Date: Wed, 1 Nov 2017 17:47:14 +0000 (UTC) archived-at: Wed, 01 Nov 2017 17:47:16 -0000 GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/873 Upgrade types and bundles as per bundle manifest headers Follow on from #872 which actually applies the upgrade in most places. One known gap, and possibly some unknown gaps, but the main cases are working. Suggest revisiting post-YOML as that will make it easier to handle upgrades due to a single instantiation path (instead of the many we currently have). You can merge this pull request into a Git repository by running: $ git pull https://github.com/ahgittin/brooklyn-server bundle-upgrade-actually-upgrade Alternatively you can review and apply these changes as the patch at: https://github.com/apache/brooklyn-server/pull/873.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #873 ---- commit a3673e4baadf6054c738e97dd3aaa3f5cc29fcc2 Author: Alex Heneveld Date: 2017-10-31T17:14:36Z store catalog upgrade instructions in osgi manager, with convenience in CatalogUpgrades commit 8b470ae58e27d49d228b54613f8d8faca5d5d729 Author: Alex Heneveld Date: 2017-11-01T11:31:42Z store catalog upgrades, and use when resolving persistence records catalog upgrades now stored in TypeRegistry, with conveniences for finding upgrades markers and comments for shifting to a "load registered type" semantics instead of "load java type" still todo is use this when we come to deploy - as per other tests commit 1453dbaadb20f108563335b082d54f247499a96d Author: Alex Heneveld Date: 2017-11-01T14:30:36Z look at upgrade targets if type or bundle not found when rebinding instances and when deploying this addresses most the places i found in the course of several tests. there may well be others, and not all the places give good logging, but those can be improved in the fullness of time (and with yoml we have many fewer creation code paths so things get simpler!) one thing that isn't addressed is within a persisted entity spec; this unpacks the definition at deploy time and persists the unpacking, rather than persisting the given entity spec yaml for use later. i think this can be addressed later. ---- ---