brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #885: Icons for adjuncts, and descriptions
Date Wed, 08 Nov 2017 11:17:31 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/885#discussion_r149640382
  
    --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/AdjunctApi.java ---
    @@ -253,4 +253,12 @@ public Response setConfig(
                 @ApiParam(value = "Whether to include subtasks recursively across different
entities (default false)", required = false)
                 @QueryParam("recurse") @DefaultValue("false") Boolean recurse);
     
    +    @GET
    +    @ApiOperation(value = "Returns an icon for the adjunct, if defined")
    +    @Path("/{adjunct}/icon")
    +    public Response getIcon(
    +        @ApiParam(value = "Application ID or name", required = true) @PathParam("application")
String applicationId,
    +        @ApiParam(value = "Entity ID or name", required = true) @PathParam("entity")
String entityId,
    +        @ApiParam(value = "Adjunct ID or name", required = true) @PathParam("adjunct")
String adjunctToken);
    +
    --- End diff --
    
    @tbouron what are you looking at?  `/v1/entities/icon/symbolicName/version` isn't a path
i'm familiar with.
    
    i've based this on `EntityApi.getIcon` which corresponds to `/v1/applications/XXX/entities/XXX/icon`
exactly as does this.
    
    `CatalogResource.getIcon` is different but we should mirror entity instances.  (you could
also use the `/v1/catalog/icon/XXX/VVV` endpoint for this but that won't look at icon tags
on the instances.)


---

Mime
View raw message