brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tbouron <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #885: Icons for adjuncts, and descriptions
Date Wed, 08 Nov 2017 10:11:12 GMT
Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/885#discussion_r149624824
  
    --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/AdjunctApi.java ---
    @@ -253,4 +253,12 @@ public Response setConfig(
                 @ApiParam(value = "Whether to include subtasks recursively across different
entities (default false)", required = false)
                 @QueryParam("recurse") @DefaultValue("false") Boolean recurse);
     
    +    @GET
    +    @ApiOperation(value = "Returns an icon for the adjunct, if defined")
    +    @Path("/{adjunct}/icon")
    +    public Response getIcon(
    +        @ApiParam(value = "Application ID or name", required = true) @PathParam("application")
String applicationId,
    +        @ApiParam(value = "Entity ID or name", required = true) @PathParam("entity")
String entityId,
    +        @ApiParam(value = "Adjunct ID or name", required = true) @PathParam("adjunct")
String adjunctToken);
    +
    --- End diff --
    
    @ahgittin Hum, so I just checked and the way the `applications` and `entities` endpoints
work is as follow: the `iconUrl` field returned by the `EntitySummary` is a relative link
to the related icon endpoint, i.e. `/v1/entities/icon/symbolicName/version`
    
    So indeed, we need this icons endpoint for adjunct. But more importantly, we should mirror
the same behaviour.


---

Mime
View raw message