brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #873: Upgrade types and bundles as per bundle m...
Date Tue, 07 Nov 2017 12:03:52 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/873#discussion_r149346988
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/persist/XmlMementoSerializer.java
---
    @@ -341,7 +371,7 @@ public void marshal(Object source, HierarchicalStreamWriter writer,
MarshallingC
             public Object unmarshal(HierarchicalStreamReader reader, UnmarshallingContext
context) {
                 if (reader.hasMoreChildren()) {
                     Class<?> type = readClassType(reader, mapper);
    -//                Class<?> type2 = context.getRequiredType();
    +                // could confirm it is subtype of context.getRequiredType()
    --- End diff --
    
    TODO to me implies a bit stronger intention, here it's a "not yet sure should we do"


---

Mime
View raw message