brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #873: Upgrade types and bundles as per bundle m...
Date Mon, 06 Nov 2017 11:21:46 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/873#discussion_r149034987
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/persist/XmlMementoSerializer.java
---
    @@ -341,7 +371,7 @@ public void marshal(Object source, HierarchicalStreamWriter writer,
MarshallingC
             public Object unmarshal(HierarchicalStreamReader reader, UnmarshallingContext
context) {
                 if (reader.hasMoreChildren()) {
                     Class<?> type = readClassType(reader, mapper);
    -//                Class<?> type2 = context.getRequiredType();
    +                // could confirm it is subtype of context.getRequiredType()
    --- End diff --
    
    Preference for a "TODO" prefix if the comment is about what we could do, rather than about
what the code does


---

Mime
View raw message