Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: ahgittin <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-126-brooklyn-library@git.apache.org>
In-Reply-To: <git-pr-126-brooklyn-library@git.apache.org>
Subject: [GitHub] brooklyn-library pull request #126: Highlights and load
Content-Type: text/plain
Message-Id: <20171004152126.10893F571A@git1-us-west.apache.org>
Date: Wed,  4 Oct 2017 15:21:26 +0000 (UTC)
archived-at: Wed, 04 Oct 2017 15:21:28 -0000

Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-library/pull/126#discussion_r142703228
  
    --- Diff: software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/mongodb/sharding/MongoDBRouterClusterImpl.java ---
    @@ -56,12 +60,17 @@ public void start(Collection<? extends Location> locations) {
         
         public static class MemberTrackingPolicy extends AbstractMembershipTrackingPolicy {
             @Override protected void onEntityEvent(EventType type, Entity member) {
    +            defaultHighlightAction(type, entity);
    --- End diff --
    
    this method overrides that method and doesn't call `super` so it has to redo it here, doesn't it?


---