brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #868: WIP - allow types from different bundles ...
Date Tue, 24 Oct 2017 16:43:31 GMT
GitHub user ahgittin opened a pull request:

    https://github.com/apache/brooklyn-server/pull/868

    WIP - allow types from different bundles if equivalent

    previously this was only allowed if older bundle was a wrapper, or if it was forced;
    this could cause problems if such a disallowed addition was forced and then you tried
to rebind!
    
    now it stores the bundle from which a registered type comes, so we can sensibly have several
types.
    we could even allow them to be different - which would of course cause chaos for users,
    but if we allow multi-tenant catalogs it will be essential (we simply have to filter for
visible
    types when looking at the registry, and prevent bundle name collisions - eg by prefixing
with tenant)
    though for now we don't allow them to be different.
    
    needs testing and test cases still

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahgittin/brooklyn-server types-disallow-same-type-different-contents-in-different-bundles

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/868.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #868
    
----
commit c380e6becf3100311620f569fd77b2f1facbc4a0
Author: Alex Heneveld <alex.heneveld@cloudsoftcorp.com>
Date:   2017-10-24T16:38:43Z

    WIP - allow types from different bundles if equivalent
    
    previously this was only allowed if older bundle was a wrapper, or if it was forced;
    this could cause problems if such a disallowed addition was forced and then you tried
to rebind!
    
    now it stores the bundle from which a registered type comes, so we can sensibly have several
types.
    we could even allow them to be different - which would of course cause chaos for users,
    but if we allow multi-tenant catalogs it will be essential (we simply have to filter for
visible
    types when looking at the registry, and prevent bundle name collisions - eg by prefixing
with tenant)
    though for now we don't allow them to be different.
    
    needs testing and test cases still

----


---

Mime
View raw message