brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #868: allow types from different bundles if equ...
Date Thu, 26 Oct 2017 12:00:08 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/868#discussion_r147119918
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java
---
    @@ -1492,7 +1503,7 @@ protected OsgiBundleInstallationResult addItemsOsgi(String yaml,
boolean forceUp
     
             OsgiBundleInstallationResult result = null;
             try {
    -            result = osgiManager.get().install(null, new FileInputStream(bf), true, true,
forceUpdate).get();
    +            result = osgiManager.get().install(new BasicManagedBundle(vn.getSymbolicName(),
vn.getVersionString(), null), new FileInputStream(bf), true, true, forceUpdate).get();
    --- End diff --
    
    has to be non-osgi version string -- that's the reason we pass in.  previously it was
inferring version from osgi bundle, then using it where the non-osgi version string was wanted.


---

Mime
View raw message