brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tbouron <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #852: Merge initial catalog and persisted catal...
Date Thu, 12 Oct 2017 15:18:42 GMT
Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/852#discussion_r144296911
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java
---
    @@ -1808,6 +1808,42 @@ public void addItem(CatalogItem<?,?> item) {
         }
     
         @Override @Deprecated /** @deprecated see super */
    +    public void addCatalogLegacyItemsOnRebind(Iterable<? extends CatalogItem<?,?>>
items) {
    +        addCatalogLegacyItemsOnRebind(items, true);
    +    }
    +    
    +    private void addCatalogLegacyItemsOnRebind(Iterable<? extends CatalogItem<?,?>>
items, boolean failOnLoadError) {
    --- End diff --
    
    This method doesn't seem to be reused so I would move it's body directly under `addCatalogLegacyItemsOnRebind(Iterable<?
extends CatalogItem<?,?>> items)`


---

Mime
View raw message