brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #835: Tasks subsystem improvements - adjuncts, ...
Date Thu, 05 Oct 2017 12:37:30 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/835#discussion_r142913075
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/config/ConfigConstraints.java ---
    @@ -112,12 +115,21 @@ public ConfigConstraints(T brooklynObject) {
         abstract Iterable<ConfigKey<?>> getBrooklynObjectTypeConfigKeys();
     
         public Iterable<ConfigKey<?>> getViolations() {
    -        // TODO in new task
    -        return validateAll();
    +        ExecutionContext exec = 
    +            getBrooklynObject() instanceof EntityInternal ? ((EntityInternal)getBrooklynObject()).getExecutionContext()
:
    +            // getBrooklynObject() instanceof AbstractEntityAdjunct ? ((AbstractEntityAdjunct)getBrooklynObject()).getExecutionContext()
:
    --- End diff --
    
    Strong believer in comments next to commented out code to say when someone would uncomment
it!


---

Mime
View raw message