brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tbouron <...@git.apache.org>
Subject [GitHub] brooklyn-library pull request #126: Highlights and load
Date Wed, 04 Oct 2017 16:14:51 GMT
Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-library/pull/126#discussion_r142718981
  
    --- Diff: qa/src/test/java/org/apache/brooklyn/qa/load/AbstractLoadTest.java ---
    @@ -161,8 +161,8 @@ protected ManagementContext setUpPlatform() {
             // Create management node
             persistenceDir = Files.createTempDir();
             launcher = BrooklynLauncher.newInstance()
    -                .persistMode(PersistMode.CLEAN)
    -                .highAvailabilityMode(HighAvailabilityMode.MASTER)
    +                .persistMode(doPersistence() ? PersistMode.CLEAN : PersistMode.DISABLED)
    +                .highAvailabilityMode(doPersistence() ? HighAvailabilityMode.MASTER :
HighAvailabilityMode.DISABLED)
    --- End diff --
    
    Good point, didn't think of the complexity due to the framework and annotation. Your solution
works so let's go with that, we can iterate on it later on


---

Mime
View raw message