brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-library pull request #126: Highlights and load
Date Wed, 04 Oct 2017 15:21:26 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-library/pull/126#discussion_r142703228
  
    --- Diff: software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/mongodb/sharding/MongoDBRouterClusterImpl.java
---
    @@ -56,12 +60,17 @@ public void start(Collection<? extends Location> locations)
{
         
         public static class MemberTrackingPolicy extends AbstractMembershipTrackingPolicy
{
             @Override protected void onEntityEvent(EventType type, Entity member) {
    +            defaultHighlightAction(type, entity);
    --- End diff --
    
    this method overrides that method and doesn't call `super` so it has to redo it here,
doesn't it?


---

Mime
View raw message