brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tbouron <...@git.apache.org>
Subject [GitHub] brooklyn-library pull request #126: Highlights and load
Date Wed, 04 Oct 2017 14:22:42 GMT
Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-library/pull/126#discussion_r142680824
  
    --- Diff: software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/mongodb/sharding/MongoDBRouterClusterImpl.java
---
    @@ -56,12 +60,17 @@ public void start(Collection<? extends Location> locations)
{
         
         public static class MemberTrackingPolicy extends AbstractMembershipTrackingPolicy
{
             @Override protected void onEntityEvent(EventType type, Entity member) {
    +            defaultHighlightAction(type, entity);
                 ((MongoDBRouterClusterImpl)super.entity).setAnyRouter();
             }
             @Override protected void onEntityRemoved(Entity member) {
    +            // TODO shouldn't be invoked - remove
    +            log.warn("Removal handler should be hidden by event handler", new Throwable("Trace
for unexpected mongo node handler"));
    --- End diff --
    
    Not sure I understand what this is for: is this an error per se? Looks like a removal
is handled correctly so why the warn message? Can you give a bit more details ?


---

Mime
View raw message