brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #816: Tasks code improvements - prep for better presen...
Date Tue, 03 Oct 2017 14:23:12 GMT
Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/816
  
    both the `getImmediately(Task)` usages you flag are DSL items which internally are TaskFactory
creating ad hoc task instances for each evaluation.  these they *do* want cancelled else they
leak (every request to `getImmediately` results in a blocking task, even though the caller
is no longer interested in them).  this PR doesn't change that behaviour -- it just makes
it clearer in javadoc -- and i think it's right enough.
    
    would be better to pass the `TaskFactory` for the avoidance of doubt and warn wherever
there is an ambiguous task evaluated in that context (or set as config).  will follow in #835.
    
    merging now (everything else is addressed)


---

Mime
View raw message