brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andreaturli <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #849: Retrieve the right AWS metadata for priva...
Date Mon, 02 Oct 2017 14:24:16 GMT
Github user andreaturli commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/849#discussion_r142153028
  
    --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
    @@ -2957,7 +2957,7 @@ String getHostnameAws(HostAndPort hostAndPort, LoginCredentials
userCredentials,
                         "get public AWS hostname",
                         ImmutableList.of(
                                 BashCommands.INSTALL_CURL,
    -                            "echo `curl --silent --retry 20 http://169.254.169.254/latest/meta-data/public-hostname`;
exit"));
    +                            "echo `curl --silent --retry 20 http://169.254.169.254/latest/meta-data/"+(privateHost
? "local-hostname" : "public-hostname")+"`; exit"));
    --- End diff --
    
    sorry @tbouron, `String getHostnameAws(...)` is already very confusing, not mentioning
the fact that is AWS specific which is another smell, IMHO.
    Which hostname is going to return that method? 
    I think we have the chance to improve this area of the code and I think another (boolean)
parameter is not going to help in that respect. wdyt?


---

Mime
View raw message