brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #841: BROOKLYN-538: add failing test
Date Thu, 21 Sep 2017 12:52:57 GMT
GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/841

    BROOKLYN-538: add failing test

    Adds a test that demonstrates https://issues.apache.org/jira/browse/BROOKLYN-538
    
    I'm going to mark issue as "won't fix" for the following reasons:
    * The exception is benign - the sensor gets the expected value of `null`
    * The exception happens deep within the `JsonPath` library - it might well be the right
behaviour for it to fail if you ask for path `$` on a null object.
    * Working around it in Brooklyn code would be added complexity for no real benefit.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server BROOKLYN-538-json-parsing-null

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/841.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #841
    
----
commit 67f1661dbf6963423aaecb8dbf1399f00e356f55
Author: Aled Sage <aled.sage@gmail.com>
Date:   2017-09-21T12:49:47Z

    BROOKLYN-538: add failing test

----


---

Mime
View raw message