brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Duncan Godwin <duncan.god...@cloudsoftcorp.com>
Subject Re: Deprecating `@Catalog` annotation?
Date Fri, 15 Sep 2017 13:50:43 GMT
+1

On 15 September 2017 at 14:47, Mark McKenna <m4rkmckenna@apache.org> wrote:

> +1
>
> On 15 September 2017 at 14:13, Geoff Macartney <
> geoff.macartney@cloudsoft.io
> > wrote:
>
> > Sounds good to me.
> >
> > On Fri, 15 Sep 2017 at 14:13 Aled Sage <aled.sage@gmail.com> wrote:
> >
> > > Hi all,
> > >
> > > I'd like to deprecate the `@Catalog` annotation [1], and the support
> for
> > > `scanFromAnnotations` [2].
> > >
> > > Previously, we annotated some entity/policy Java classes with catalog
> > > information, such as descriptions and icon urls. However, we've moved
> to
> > > using .bom files as the way to define catalog items. Therefore the
> > > `@Catalog` is not normally used.
> > >
> > > It is also supported/used by the `./brooklyn list-objects` CLI, to scan
> > > jars [3]. It find the annotated entities etc, gets the catalog
> metadata,
> > > and writes that out in json format. However, I don't think that's what
> > > we want to do moving forward. We should focus on getting the metadata
> > > from the .bom files, which is how things should be defined for the
> > catalog.
> > >
> > > Any objections to deprecating these?
> > >
> > > Aled
> > >
> > > [1]
> > >
> > > https://github.com/apache/brooklyn-server/blob/master/
> > api/src/main/java/org/apache/brooklyn/api/catalog/Catalog.java
> > > [2]
> > >
> > > https://github.com/apache/brooklyn-server/blob/master/
> > core/src/main/java/org/apache/brooklyn/core/catalog/
> > internal/CatalogClasspathDo.java#L199-L209
> > > [3]
> > >
> > > https://github.com/apache/brooklyn-server/blob/master/
> > server-cli/src/main/java/org/apache/brooklyn/cli/ItemLister.java#L88-L94
> > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message