brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tbouron <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #829: [WIP] BROOKLYN-535: restarter policy when...
Date Fri, 29 Sep 2017 09:51:55 GMT
Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/829#discussion_r141826617
  
    --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/ServiceRestarter.java ---
    @@ -133,6 +135,10 @@ protected synchronized void onDetectedFailure(SensorEvent<Object>
event) {
                 LOG.warn("ServiceRestarter suspended, so not acting on failure detected at
"+entity+" ("+event.getValue()+")");
                 return;
             }
    +        if (isEntityStopping()) {
    +            highlightViolation("Failure detected but entity stopping");
    --- End diff --
    
    Should we highlight the violation here? I guess the question is more: is it really a violation
when we are in a stopping state?


---

Mime
View raw message